Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Issue 664583002: Remove obsolete SkRecord preview code. (Closed)

Created:
6 years, 2 months ago by mtklein_C
Modified:
6 years, 2 months ago
CC:
chromium-reviews, mkwst+moarreviews-renderer_chromium.org, darin-cc_chromium.org, cc-bugs_chromium.org, jam, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Remove obsolete SkRecord preview code. SkRecord backs SkPictureRecorder::beginRecording() (the normal path) now. BUG= Committed: https://crrev.com/c893bf973dc0077797ec9321315bcdf39e15a123 Cr-Commit-Position: refs/heads/master@{#300111}

Patch Set 1 #

Patch Set 2 : retry #

Patch Set 3 : more #

Patch Set 4 : yet more #

Patch Set 5 : unloop #

Patch Set 6 : missed #

Patch Set 7 : update r&r micro, and format #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -148 lines) Patch
M cc/debug/rasterize_and_record_benchmark.cc View 1 2 3 4 5 6 1 chunk +3 lines, -1 line 0 comments Download
M cc/layers/picture_layer.h View 1 2 3 1 chunk +0 lines, -2 lines 0 comments Download
M cc/layers/picture_layer.cc View 1 2 3 2 chunks +1 line, -12 lines 0 comments Download
M cc/layers/picture_layer_unittest.cc View 1 2 3 1 chunk +0 lines, -17 lines 0 comments Download
M cc/resources/picture.h View 3 chunks +0 lines, -3 lines 0 comments Download
M cc/resources/picture.cc View 6 chunks +3 lines, -38 lines 0 comments Download
M cc/resources/picture_unittest.cc View 1 2 3 4 5 6 2 chunks +44 lines, -61 lines 0 comments Download
M cc/trees/layer_tree_settings.h View 1 2 1 chunk +0 lines, -5 lines 0 comments Download
M cc/trees/layer_tree_settings.cc View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/gpu/render_widget_compositor.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M tools/perf/measurements/rasterize_and_record_micro.py View 1 2 3 4 5 6 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 19 (7 generated)
mtklein_C
6 years, 2 months ago (2014-10-16 20:37:09 UTC) #2
enne (OOO)
lgtm
6 years, 2 months ago (2014-10-16 21:05:54 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/664583002/100001
6 years, 2 months ago (2014-10-16 21:08:49 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/18182)
6 years, 2 months ago (2014-10-16 21:17:51 UTC) #7
mtklein_C
+jamesr: mind stamping this for content/ ?
6 years, 2 months ago (2014-10-16 21:21:47 UTC) #9
jamesr
content/renderer/ lgtm
6 years, 2 months ago (2014-10-16 21:28:35 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/664583002/100001
6 years, 2 months ago (2014-10-16 21:31:51 UTC) #12
mtklein
+skyostil... can you stamp me for R&R micros?
6 years, 2 months ago (2014-10-16 21:46:43 UTC) #14
Sami
tools/perf/measurements/rasterize_and_record_micro.py lgtm.
6 years, 2 months ago (2014-10-17 10:20:54 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/664583002/120001
6 years, 2 months ago (2014-10-17 13:22:54 UTC) #17
commit-bot: I haz the power
Committed patchset #7 (id:120001)
6 years, 2 months ago (2014-10-17 15:16:15 UTC) #18
commit-bot: I haz the power
6 years, 2 months ago (2014-10-17 15:17:01 UTC) #19
Message was sent while issue was closed.
Patchset 7 (id:??) landed as
https://crrev.com/c893bf973dc0077797ec9321315bcdf39e15a123
Cr-Commit-Position: refs/heads/master@{#300111}

Powered by Google App Engine
This is Rietveld 408576698