Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Unified Diff: chrome/browser/ssl/ssl_blocking_page.h

Issue 664503006: Implementation of the full clock interstitial. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Prevent "danger" override on clock interstitial. Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ssl/ssl_blocking_page.h
diff --git a/chrome/browser/ssl/ssl_blocking_page.h b/chrome/browser/ssl/ssl_blocking_page.h
index ff575ae5304f44060a3e19266372017b3c77f713..c2bf1ad849ee88c8a59da9a3e0ad8c7e7ecc9c98 100644
--- a/chrome/browser/ssl/ssl_blocking_page.h
+++ b/chrome/browser/ssl/ssl_blocking_page.h
@@ -105,6 +105,9 @@ class SSLBlockingPage : public content::InterstitialPageDelegate {
// Could the user successfully override the error?
// overridable_ will be set to false if strict_enforcement_ is true.
const bool overridable_;
felt 2014/10/23 23:19:03 ^ Can you add a note specifying that this controls
+ // The user can override an SSL error by typing the word "danger" into
+ // the interstitial. This bool can be set to false to prevent the behaviour.
felt 2014/10/23 23:19:03 ^ Can you explain that this applies regardless of
+ bool danger_overridable_;
// Has the site requested strict enforcement of certificate errors?
const bool strict_enforcement_;
content::InterstitialPage* interstitial_page_; // Owns us.

Powered by Google App Engine
This is Rietveld 408576698