Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(233)

Side by Side Diff: chrome/browser/ssl/ssl_blocking_page.h

Issue 664503006: Implementation of the full clock interstitial. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Prevent "danger" override on clock interstitial. Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_SSL_SSL_BLOCKING_PAGE_H_ 5 #ifndef CHROME_BROWSER_SSL_SSL_BLOCKING_PAGE_H_
6 #define CHROME_BROWSER_SSL_SSL_BLOCKING_PAGE_H_ 6 #define CHROME_BROWSER_SSL_SSL_BLOCKING_PAGE_H_
7 7
8 #include <string> 8 #include <string>
9 #include <vector> 9 #include <vector>
10 10
(...skipping 86 matching lines...) Expand 10 before | Expand all | Expand 10 after
97 void OnGotHistoryCount(bool success, int num_visits, base::Time first_visit); 97 void OnGotHistoryCount(bool success, int num_visits, base::Time first_visit);
98 98
99 base::Callback<void(bool)> callback_; 99 base::Callback<void(bool)> callback_;
100 100
101 content::WebContents* web_contents_; 101 content::WebContents* web_contents_;
102 const int cert_error_; 102 const int cert_error_;
103 const net::SSLInfo ssl_info_; 103 const net::SSLInfo ssl_info_;
104 const GURL request_url_; 104 const GURL request_url_;
105 // Could the user successfully override the error? 105 // Could the user successfully override the error?
106 // overridable_ will be set to false if strict_enforcement_ is true. 106 // overridable_ will be set to false if strict_enforcement_ is true.
107 const bool overridable_; 107 const bool overridable_;
felt 2014/10/23 23:19:03 ^ Can you add a note specifying that this controls
108 // The user can override an SSL error by typing the word "danger" into
109 // the interstitial. This bool can be set to false to prevent the behaviour.
felt 2014/10/23 23:19:03 ^ Can you explain that this applies regardless of
110 bool danger_overridable_;
108 // Has the site requested strict enforcement of certificate errors? 111 // Has the site requested strict enforcement of certificate errors?
109 const bool strict_enforcement_; 112 const bool strict_enforcement_;
110 content::InterstitialPage* interstitial_page_; // Owns us. 113 content::InterstitialPage* interstitial_page_; // Owns us.
111 // Is the hostname for an internal network? 114 // Is the hostname for an internal network?
112 bool internal_; 115 bool internal_;
113 // How many times is this same URL in history? 116 // How many times is this same URL in history?
114 int num_visits_; 117 int num_visits_;
115 // Used for getting num_visits_. 118 // Used for getting num_visits_.
116 base::CancelableTaskTracker request_tracker_; 119 base::CancelableTaskTracker request_tracker_;
117 // Did the user previously allow a bad certificate but the decision has now 120 // Did the user previously allow a bad certificate but the decision has now
118 // expired? 121 // expired?
119 const bool expired_but_previously_allowed_; 122 const bool expired_but_previously_allowed_;
120 scoped_ptr<SSLErrorClassification> ssl_error_classification_; 123 scoped_ptr<SSLErrorClassification> ssl_error_classification_;
121 124
122 #if defined(ENABLE_EXTENSIONS) 125 #if defined(ENABLE_EXTENSIONS)
123 // For Chrome Experience Sampling Platform: this maintains event state. 126 // For Chrome Experience Sampling Platform: this maintains event state.
124 scoped_ptr<extensions::ExperienceSamplingEvent> sampling_event_; 127 scoped_ptr<extensions::ExperienceSamplingEvent> sampling_event_;
125 #endif 128 #endif
126 129
127 content::NotificationRegistrar registrar_; 130 content::NotificationRegistrar registrar_;
128 131
129 DISALLOW_COPY_AND_ASSIGN(SSLBlockingPage); 132 DISALLOW_COPY_AND_ASSIGN(SSLBlockingPage);
130 }; 133 };
131 134
132 #endif // CHROME_BROWSER_SSL_SSL_BLOCKING_PAGE_H_ 135 #endif // CHROME_BROWSER_SSL_SSL_BLOCKING_PAGE_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698