Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1021)

Issue 664483004: Make IsProxyBypassed work when there are no bad proxies. (Closed)

Created:
6 years, 2 months ago by sclittle
Modified:
6 years, 1 month ago
Reviewers:
bengr, bolian
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Make IsProxyBypassed work when there are no bad proxies. Currently, if there are no bad proxies, IsProxyBypassed will cause a runtime error. This change makes it return (False, []) as expected. BUG=427666 Committed: https://crrev.com/b904b15f3e24cbcaaec47cc3c9a88c4952ca116c Cr-Commit-Position: refs/heads/master@{#301470}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M tools/chrome_proxy/integration_tests/chrome_proxy_metrics.py View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (4 generated)
sclittle
6 years, 2 months ago (2014-10-23 22:14:35 UTC) #2
bolian
lgtm
6 years, 2 months ago (2014-10-23 22:29:55 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/664483004/1
6 years, 1 month ago (2014-10-27 18:30:18 UTC) #5
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 1 month ago (2014-10-27 18:30:21 UTC) #7
bengr
lgtm, but this needs a bug number.
6 years, 1 month ago (2014-10-27 21:18:08 UTC) #8
sclittle
Added bug number to CL description.
6 years, 1 month ago (2014-10-27 21:30:03 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/664483004/1
6 years, 1 month ago (2014-10-27 21:31:43 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-10-27 23:09:29 UTC) #12
commit-bot: I haz the power
6 years, 1 month ago (2014-10-27 23:09:44 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b904b15f3e24cbcaaec47cc3c9a88c4952ca116c
Cr-Commit-Position: refs/heads/master@{#301470}

Powered by Google App Engine
This is Rietveld 408576698