tools/chrome_proxy/integration_tests/chrome_proxy_metrics.py - Issue 664483004: Make IsProxyBypassed work when there are no bad proxies.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/chrome_proxy/integration_tests/chrome_proxy_metrics.py

Issue 664483004: Make IsProxyBypassed work when there are no bad proxies. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/chrome_proxy/integration_tests/chrome_proxy_metrics.py

diff --git a/tools/chrome_proxy/integration_tests/chrome_proxy_metrics.py b/tools/chrome_proxy/integration_tests/chrome_proxy_metrics.py

index adcc24119d44203115f6ac398875be9ccb145e19..5d7ff72527832150c7f8a28bd083f809349a7243 100644

--- a/tools/chrome_proxy/integration_tests/chrome_proxy_metrics.py

+++ b/tools/chrome_proxy/integration_tests/chrome_proxy_metrics.py

@@ -191,6 +191,9 @@ class ChromeProxyMetric(network_metrics.NetworkMetric):

raise ChromeProxyMetricException, (

'Chrome proxy should be enabled. proxy info: %s' % info)

+ if not info['badProxies']:

+ return False, []

bad_proxies = [str(p['proxy']) for p in info['badProxies']]

bad_proxies.sort()

proxies = [self.effective_proxies['proxy'],

« no previous file with comments | « no previous file | no next file » | no next file with comments »