Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(182)

Issue 664433003: [ServiceWorkerCacheStorage] Add support for new Open method. (Closed)

Created:
6 years, 2 months ago by jkarlin
Modified:
6 years, 2 months ago
Reviewers:
Tom Sepez, falken, michaeln
CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, tzik, serviceworker-reviews, jam, kinuko+serviceworker, nhiroki, mkwst+moarreviews-ipc_chromium.org, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org, horo+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[ServiceWorkerCacheStorage] Add support for new Open method. Create/Get have been replaced by Open which will first attempt to Get() followed by Create() if Get() failed. CLs in this three-legged-patch: *1. Add open to browser - https://codereview.chromium.org/664433003/ 2. Add open (remove get/create) to Blink - https://codereview.chromium.org/638023003 3. Remove get/create from browser - https://codereview.chromium.org/663503002/ Note that the three CLs have been tested together and pass tests locally. BUG=423942 Committed: https://crrev.com/56f997e36d2148a03cb11773644505345cdcf1f2 Cr-Commit-Position: refs/heads/master@{#300047}

Patch Set 1 #

Patch Set 2 : Update open function #

Patch Set 3 : Dispatch the response #

Messages

Total messages: 10 (3 generated)
jkarlin
falken@chromium.org: Please review changes in everything michaeln@chromium.org: Please review changes in everything tsepez@chromium.org: Please review ...
6 years, 2 months ago (2014-10-16 12:12:35 UTC) #2
Tom Sepez
Messages LGTM.
6 years, 2 months ago (2014-10-16 16:40:30 UTC) #4
falken
lgtm
6 years, 2 months ago (2014-10-17 01:34:33 UTC) #5
michaeln
lgtm 2
6 years, 2 months ago (2014-10-17 01:45:52 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/664433003/60001
6 years, 2 months ago (2014-10-17 01:56:18 UTC) #8
commit-bot: I haz the power
Committed patchset #3 (id:60001)
6 years, 2 months ago (2014-10-17 02:38:10 UTC) #9
commit-bot: I haz the power
6 years, 2 months ago (2014-10-17 02:39:05 UTC) #10
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/56f997e36d2148a03cb11773644505345cdcf1f2
Cr-Commit-Position: refs/heads/master@{#300047}

Powered by Google App Engine
This is Rietveld 408576698