Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Unified Diff: content/browser/service_worker/service_worker_cache_storage_manager_unittest.cc

Issue 664433003: [ServiceWorkerCacheStorage] Add support for new Open method. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Dispatch the response Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/service_worker/service_worker_cache_storage_manager_unittest.cc
diff --git a/content/browser/service_worker/service_worker_cache_storage_manager_unittest.cc b/content/browser/service_worker/service_worker_cache_storage_manager_unittest.cc
index a9cf8fbfe7b6632c1c86db3540957242a51f19a0..ab142ae3757bb1002c27253ffcdcda300740f8bb 100644
--- a/content/browser/service_worker/service_worker_cache_storage_manager_unittest.cc
+++ b/content/browser/service_worker/service_worker_cache_storage_manager_unittest.cc
@@ -140,6 +140,25 @@ class ServiceWorkerCacheStorageManagerTest : public testing::Test {
return !error;
}
+ bool Open(const GURL& origin, const std::string& cache_name) {
+ scoped_ptr<base::RunLoop> loop(new base::RunLoop());
+ cache_manager_->OpenCache(
+ origin,
+ cache_name,
+ base::Bind(&ServiceWorkerCacheStorageManagerTest::CacheAndErrorCallback,
+ base::Unretained(this),
+ base::Unretained(loop.get())));
+ loop->Run();
+
+ bool error = callback_error_ !=
+ ServiceWorkerCacheStorage::CACHE_STORAGE_ERROR_NO_ERROR;
+ if (error)
+ EXPECT_TRUE(!callback_cache_.get());
+ else
+ EXPECT_TRUE(callback_cache_.get());
+ return !error;
+ }
+
bool Has(const GURL& origin, const std::string& cache_name) {
scoped_ptr<base::RunLoop> loop(new base::RunLoop());
cache_manager_->HasCache(
@@ -295,6 +314,17 @@ TEST_P(ServiceWorkerCacheStorageManagerTestP, GetNonExistent) {
callback_error_);
}
+TEST_P(ServiceWorkerCacheStorageManagerTestP, OpenNewCache) {
+ EXPECT_TRUE(Open(origin1_, "foo"));
+}
+
+TEST_P(ServiceWorkerCacheStorageManagerTestP, OpenExistingCache) {
+ EXPECT_TRUE(CreateCache(origin1_, "foo"));
+ scoped_refptr<ServiceWorkerCache> cache = callback_cache_;
+ EXPECT_TRUE(Open(origin1_, "foo"));
+ EXPECT_TRUE(cache.get() == callback_cache_.get());
+}
+
TEST_P(ServiceWorkerCacheStorageManagerTestP, HasCache) {
EXPECT_TRUE(CreateCache(origin1_, "foo"));
EXPECT_TRUE(Has(origin1_, "foo"));

Powered by Google App Engine
This is Rietveld 408576698