[SVG] Move negative viewBox width/height reporting to SVGAnimatedViewBoxRect

[SVG] Move negative viewBox width/height reporting to SVGAnimatedViewBoxRect

Before this CL, SVGFitToViewBox::parseAttribute handled negative width, height
errors inline. To migrate parsing to property map (crbug.com/397902), we want
to delegate this to SVGAnimatedProperty::setBaseValueToString implementation.

This CL introduces SVGAnimatedViewBoxRect which is a SVGAnimatedRect implements
handling of negative width/height.

TEST=svg/custom/viewbox-syntax.svg
BUG=397902
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183802

[kouhei (in TOK), 2014-10-16 07:10:51]

kouhei@chromium.org changed reviewers:
+ fs@opera.com, haraken@chromium.org, pdr@chromium.org

[fs, 2014-10-16 08:11:55]

lgtm

https://codereview.chromium.org/664433002/diff/20001/Source/core/svg/SVGFitTo...
File Source/core/svg/SVGFitToViewBox.cpp (right):

https://codereview.chromium.org/664433002/diff/20001/Source/core/svg/SVGFitTo...
Source/core/svg/SVGFitToViewBox.cpp:63: if (baseValue()->width() < 0.0f) {
Nit: I don't mind personally, but I think that coding style dictates that "0"
should be used here.

(I'd probably have merged these to into "foo || bar" since the body is identical
- but that's because I don't trust that the compiler will do it =))

[kouhei (in TOK), 2014-10-16 09:04:52]

Thanks for review!

On 2014/10/16 08:11:55, fs wrote:
> lgtm
> 
>
https://codereview.chromium.org/664433002/diff/20001/Source/core/svg/SVGFitTo...
> File Source/core/svg/SVGFitToViewBox.cpp (right):
> 
>
https://codereview.chromium.org/664433002/diff/20001/Source/core/svg/SVGFitTo...
> Source/core/svg/SVGFitToViewBox.cpp:63: if (baseValue()->width() < 0.0f) {
> Nit: I don't mind personally, but I think that coding style dictates that "0"
> should be used here.
> 
> (I'd probably have merged these to into "foo || bar" since the body is
identical
> - but that's because I don't trust that the compiler will do it =))

Makes sense. Fixed!

[kouhei (in TOK), 2014-10-16 09:04:56]

The CQ bit was checked by kouhei@chromium.org

[commit-bot: I haz the power, 2014-10-16 09:05:19]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/664433002/40001

[commit-bot: I haz the power, 2014-10-16 10:39:36]

Committed patchset #3 (id:40001) as 183802