[SVG] Move negative viewBox width/height reporting to SVGAnimatedViewBoxRect

Source/core/svg/SVGFitToViewBox.cpp

 /*
  * Copyright (C) 2004, 2005, 2008 Nikolas Zimmermann <zimmermann@kde.org>
  * Copyright (C) 2004, 2005, 2006, 2007, 2010 Rob Buis <buis@kde.org>
  * Copyright (C) 2014 Samsung Electronics. All rights reserved.
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
  * version 2 of the License, or (at your option) any later version.
  *
@@ skipping 15 matching lines @@
 #include "core/dom/Attribute.h"
 #include "core/svg/SVGDocumentExtensions.h"
 #include "core/svg/SVGElement.h"
 #include "core/svg/SVGParserUtilities.h"
 #include "platform/geometry/FloatRect.h"
 #include "platform/transforms/AffineTransform.h"
 #include "wtf/text/StringImpl.h"
 
 namespace blink {
 
+class SVGAnimatedViewBoxRect : public SVGAnimatedRect {
+public:
+    static PassRefPtr<SVGAnimatedRect> create(SVGElement* contextElement)
+    {
+        return adoptRef(new SVGAnimatedViewBoxRect(contextElement));
+    }
+
+    void setBaseValueAsString(const String&, SVGParsingError&) override;
+
+protected:
+    SVGAnimatedViewBoxRect(SVGElement* contextElement)
+        : SVGAnimatedRect(contextElement, SVGNames::viewBoxAttr)
+    {
+    }
+};
+
+void SVGAnimatedViewBoxRect::setBaseValueAsString(const String& value, SVGParsingError& parseError)
+{
+    TrackExceptionState es;
+
+    baseValue()->setValueAsString(value, es);
+
+    if (es.hadException()) {
+        parseError = ParsingAttributeFailedError;
+        return;
+    }
+
+    if (baseValue()->width() < 0.0f) {

[fs, 2014/10/16 08:11:55]

Nit: I don't mind personally, but I think that coding style dictates that "0"
should be used here.

(I'd probably have merged these to into "foo || bar" since the body is identical
- but that's because I don't trust that the compiler will do it =))

+        parseError = NegativeValueForbiddenError;
+        baseValue()->setInvalid();
+        return;
+    }
+    if (baseValue()->height() < 0.0f) {
+        parseError = NegativeValueForbiddenError;
+        baseValue()->setInvalid();
+        return;
+    }
+}
+
 SVGFitToViewBox::SVGFitToViewBox(SVGElement* element, PropertyMapPolicy propertyMapPolicy)
-    : m_viewBox(SVGAnimatedRect::create(element, SVGNames::viewBoxAttr))
+    : m_viewBox(SVGAnimatedViewBoxRect::create(element))
     , m_preserveAspectRatio(SVGAnimatedPreserveAspectRatio::create(element, SVGNames::preserveAspectRatioAttr, SVGPreserveAspectRatio::create()))
 {
     ASSERT(element);
     if (propertyMapPolicy == PropertyMapPolicyAdd) {
         element->addToPropertyMap(m_viewBox);
         element->addToPropertyMap(m_preserveAspectRatio);
     }
 }
 
 AffineTransform SVGFitToViewBox::viewBoxToViewTransform(const FloatRect& viewBoxRect, PassRefPtr<SVGPreserveAspectRatio> preserveAspectRatio, float viewWidth, float viewHeight)
@@ skipping 15 matching lines @@
     supportedAttributes.add(SVGNames::preserveAspectRatioAttr);
 }
 
 void SVGFitToViewBox::updateViewBox(const FloatRect& rect)
 {
     ASSERT(m_viewBox);
     m_viewBox->baseValue()->setValue(rect);
 }
 
 }