Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issue 664343005: [ServiceWorker] Check ignore_certificate_errors flag in ServiceWorkerWriteToCacheJob (Closed)

Created:
6 years, 2 months ago by horo
Modified:
6 years, 2 months ago
Reviewers:
michaeln
CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, tzik, serviceworker-reviews, jam, kinuko+serviceworker, nhiroki, darin-cc_chromium.org, horo+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[ServiceWorker] Check ignore_certificate_errors flag in ServiceWorkerWriteToCacheJob. https://codereview.chromium.org/643773004 broke LayoutTest fetch-mixed-content.html. While executing LayoutTest, ignore_certificate_errors is set in LayoutTestBrowserContext. So every cert errors are ignored in HttpStreamFactoryImpl::Job::HandleCertificateError. At this case we should also ignore the cert errors in ServiceWorkerWriteToCacheJob. BUG=426047, 425396 Committed: https://crrev.com/ee19788135cd12b718feed2550ae5a98dc78abdb Cr-Commit-Position: refs/heads/master@{#300989}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -3 lines) Patch
M content/browser/service_worker/service_worker_write_to_cache_job.cc View 2 chunks +8 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
horo
michaeln@ Could you please review this?
6 years, 2 months ago (2014-10-23 04:56:17 UTC) #2
michaeln
nice, lgtm
6 years, 2 months ago (2014-10-23 21:06:24 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/664343005/1
6 years, 2 months ago (2014-10-23 22:27:02 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-23 23:52:21 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-10-23 23:52:38 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ee19788135cd12b718feed2550ae5a98dc78abdb
Cr-Commit-Position: refs/heads/master@{#300989}

Powered by Google App Engine
This is Rietveld 408576698