Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(274)

Issue 643773004: [ServiceWorker] Don't register ServiceWorker with an invalid HTTPS certificate. (Closed)

Created:
6 years, 2 months ago by horo
Modified:
6 years, 2 months ago
Reviewers:
michaeln
CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, tzik, serviceworker-reviews, jam, kinuko+serviceworker, nhiroki, darin-cc_chromium.org, horo+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[ServiceWorker] Don't register ServiceWorker with an invalid HTTPS certificate. BUG=425396, 414026 Committed: https://crrev.com/a8ac964e0cf580c4e72028f81f1cda335436659d Cr-Commit-Position: refs/heads/master@{#300644}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -2 lines) Patch
M content/browser/service_worker/service_worker_write_to_cache_job.cc View 3 chunks +9 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (3 generated)
horo
michaeln@ Could you please review this? Thank you!
6 years, 2 months ago (2014-10-21 03:40:47 UTC) #3
Michael van Ouwerkerk
Drive-by comment: do you need a new test to cover this change?
6 years, 2 months ago (2014-10-21 09:48:39 UTC) #4
michaeln
lgtm!
6 years, 2 months ago (2014-10-21 19:35:19 UTC) #5
horo
On 2014/10/21 09:48:39, Michael van Ouwerkerk wrote: > Drive-by comment: do you need a new ...
6 years, 2 months ago (2014-10-22 06:22:29 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/643773004/20001
6 years, 2 months ago (2014-10-22 06:23:59 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:20001)
6 years, 2 months ago (2014-10-22 07:13:22 UTC) #9
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/a8ac964e0cf580c4e72028f81f1cda335436659d Cr-Commit-Position: refs/heads/master@{#300644}
6 years, 2 months ago (2014-10-22 07:14:14 UTC) #10
jsbell
On 2014/10/22 07:14:14, I haz the power (commit-bot) wrote: > Patchset 1 (id:??) landed as ...
6 years, 2 months ago (2014-10-22 16:27:24 UTC) #11
michaeln1
On 2014/10/22 16:27:24, jsbell wrote: > On 2014/10/22 07:14:14, I haz the power (commit-bot) wrote: ...
6 years, 2 months ago (2014-10-22 16:56:07 UTC) #12
jsbell
6 years, 2 months ago (2014-10-22 18:17:34 UTC) #13
Message was sent while issue was closed.
On 2014/10/22 16:56:07, michaeln1 wrote:
> On 2014/10/22 16:27:24, jsbell wrote:
> > On 2014/10/22 07:14:14, I haz the power (commit-bot) wrote:
> > > Patchset 1 (id:??) landed as
> > > https://crrev.com/a8ac964e0cf580c4e72028f81f1cda335436659d
> > > Cr-Commit-Position: refs/heads/master@{#300644}
> > 
> > http/tests/serviceworker/fetch-mixed-content.html is failing following this
> > change:
> > 
> >
>
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=htt...
> 
> Does the https server used for layout tests have a valid ssl cert?

Our code doesn't think so. :)

I filed crbug.com/426047 to track the failure.

Powered by Google App Engine
This is Rietveld 408576698