test/errors/file_cycle0.gyp - Issue 664253005: Simplify and optimize FindCycles

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: test/errors/file_cycle0.gyp

Issue 664253005: Simplify and optimize FindCycles (Closed) Base URL: https://chromium.googlesource.com/external/gyp.git@master

Patch Set: Add test for file cycle and fix file full cycle case Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: test/errors/file_cycle0.gyp

diff --git a/test/variables/commands/repeated_multidir/main.gyp b/test/errors/file_cycle0.gyp

similarity index 59%

copy from test/variables/commands/repeated_multidir/main.gyp

copy to test/errors/file_cycle0.gyp

index 5beeeb7244d2e9f95f01c35d506d62b4afa5ad09..3bfafb6cb393781e848ce737545c6e3cf9fccde3 100644

--- a/test/variables/commands/repeated_multidir/main.gyp

+++ b/test/errors/file_cycle0.gyp

@@ -5,12 +5,13 @@

{

'targets': [

{

- 'target_name': 'main',

+ 'target_name': 'top',

+ 'type': 'none',

+ 'dependencies': [ 'file_cycle1.gyp:middle' ],

+ },

+ {

+ 'target_name': 'bottom',

'type': 'none',

- 'dependencies': [

- 'dir_1/test_1.gyp:target_1',

- 'dir_2/test_2.gyp:target_2',

- ],

}