test/errors/file_cycle0.gyp - Issue 664253005: Simplify and optimize FindCycles

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: test/errors/file_cycle0.gyp

Issue 664253005: Simplify and optimize FindCycles (Closed) Base URL: https://chromium.googlesource.com/external/gyp.git@master

Patch Set: Add test for file cycle and fix file full cycle case Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 # Copyright 2014 Google Inc. All rights reserved.	1 # Copyright 2014 Google Inc. All rights reserved.

2 # Use of this source code is governed by a BSD-style license that can be	2 # Use of this source code is governed by a BSD-style license that can be

3 # found in the LICENSE file.	3 # found in the LICENSE file.

4	4

5 {	5 {

6 'targets': [	6 'targets': [

7 {	7 {

8 'target_name': 'main',	8 'target_name': 'top',

9 'type': 'none',	9 'type': 'none',

10 'dependencies': [	10 'dependencies': [ 'file_cycle1.gyp:middle' ],

11 'dir_1/test_1.gyp:target_1',	11 },

12 'dir_2/test_2.gyp:target_2',	12 {

13 ],	13 'target_name': 'bottom',

	14 'type': 'none',

14 },	15 },

15 ],	16 ],

16 }	17 }

OLD	NEW