cc/layers/ui_resource_layer.h - Issue 664173002: Prevent recreation of UI resource holder when created with resource ID

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cc/layers/ui_resource_layer.h

Issue 664173002: Prevent recreation of UI resource holder when created with resource ID (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fixed not to recreate when not necessary Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: cc/layers/ui_resource_layer.h

diff --git a/cc/layers/ui_resource_layer.h b/cc/layers/ui_resource_layer.h

index 3bfd9b2f109d1d0e995060d4d63141f21772d96b..bb17264676c658481cdb8f844de9aaa748e00822 100644

--- a/cc/layers/ui_resource_layer.h

+++ b/cc/layers/ui_resource_layer.h

@@ -43,6 +43,7 @@ class CC_EXPORT UIResourceLayer : public Layer {

public:

virtual UIResourceId id() = 0;

virtual ~UIResourceHolder();

+ virtual bool NeedsRecreation();

danakj 2014/10/27 18:47:08 why not pure virtual?

Changwan Ryu 2014/10/28 00:39:18 Done.

};

protected:

« no previous file with comments | « no previous file | cc/layers/ui_resource_layer.cc » ('j') | cc/layers/ui_resource_layer.cc » ('J')