Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(447)

Unified Diff: cc/layers/ui_resource_layer.cc

Issue 664173002: Prevent recreation of UI resource holder when created with resource ID (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fixed not to recreate when not necessary Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« cc/layers/ui_resource_layer.h ('K') | « cc/layers/ui_resource_layer.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/layers/ui_resource_layer.cc
diff --git a/cc/layers/ui_resource_layer.cc b/cc/layers/ui_resource_layer.cc
index 944cf7d54844c7016feb32eacfc401fb590146ab..25b0e1d9f01dc6dbccf16cae79bd692de18d5bf9 100644
--- a/cc/layers/ui_resource_layer.cc
+++ b/cc/layers/ui_resource_layer.cc
@@ -41,6 +41,8 @@ class SharedUIResourceHolder : public UIResourceLayer::UIResourceHolder {
UIResourceId id() override { return id_; }
+ bool NeedsRecreation() override { return true; }
+
private:
explicit SharedUIResourceHolder(UIResourceId id) : id_(id) {}
@@ -51,6 +53,10 @@ class SharedUIResourceHolder : public UIResourceLayer::UIResourceHolder {
UIResourceLayer::UIResourceHolder::~UIResourceHolder() {}
+bool UIResourceLayer::UIResourceHolder::NeedsRecreation() {
+ return false;
+}
+
scoped_refptr<UIResourceLayer> UIResourceLayer::Create() {
return make_scoped_refptr(new UIResourceLayer());
}
@@ -112,10 +118,12 @@ void UIResourceLayer::SetLayerTreeHost(LayerTreeHost* host) {
}
void UIResourceLayer::RecreateUIResourceHolder() {
- ui_resource_holder_ = nullptr;
if (layer_tree_host() && !bitmap_.empty()) {
ui_resource_holder_ =
ScopedUIResourceHolder::Create(layer_tree_host(), bitmap_);
+ } else if (ui_resource_holder_.get() &&
danakj 2014/10/27 18:47:08 no .get() needed
Changwan Ryu 2014/10/28 00:39:18 Done.
+ !ui_resource_holder_->NeedsRecreation()) {
+ ui_resource_holder_ = nullptr;
}
UpdateDrawsContent(HasDrawableContent());
}
« cc/layers/ui_resource_layer.h ('K') | « cc/layers/ui_resource_layer.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698