Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(321)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 664163003: Update targetSdkVersion for Chromium applications. (Closed)

Created:
6 years, 2 months ago by aurimas (slooooooooow)
Modified:
6 years, 2 months ago
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, stgao, yzshen+watch_chromium.org, aandrey+blink_chromium.org, ben+mojo_chromium.org, cbentzel+watch_chromium.org, vsevik, samuong+watch_chromium.org, chromoting-reviews_chromium.org, jam, abarth-chromium, darin-cc_chromium.org, yfriedman+watch_chromium.org, devtools-reviews_chromium.org, android-webview-reviews_chromium.org, paulirish+reviews_chromium.org, mkwst+moarreviews-shell_chromium.org, klundberg+watch_chromium.org, jochen+watch_chromium.org, yurys, Aaron Boodman, darin (slow to review), pfeldman
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Update targetSdkVersion for Chromium applications. Behavior changes described here: http://developer.android.com/about/versions/android-5.0.html BUG=424680 TBR=aa@chromium.org Committed: https://crrev.com/17d3d93913930fa893c668969f1ccd5b4de746cd Cr-Commit-Position: refs/heads/master@{#300506}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -24 lines) Patch
M android_webview/javatests/AndroidManifest.xml View 1 chunk +1 line, -1 line 0 comments Download
M android_webview/test/shell/AndroidManifest.xml View 1 chunk +1 line, -1 line 0 comments Download
M build/android/AndroidManifest.xml View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/shell/java/AndroidManifest.xml View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/shell/javatests/AndroidManifest.xml View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/sync_shell/java/AndroidManifest.xml View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/sync_shell/javatests/AndroidManifest.xml View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/android/unit_tests_apk/AndroidManifest.xml View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/chromedriver/test/webview_shell/java/AndroidManifest.xml View 1 chunk +1 line, -1 line 0 comments Download
M components/cronet/android/sample/AndroidManifest.xml View 1 chunk +1 line, -1 line 0 comments Download
M components/cronet/android/sample/javatests/AndroidManifest.xml View 1 chunk +1 line, -1 line 0 comments Download
M components/cronet/android/test/AndroidManifest.xml View 1 chunk +1 line, -1 line 0 comments Download
M components/cronet/android/test/javatests/AndroidManifest.xml View 1 chunk +1 line, -1 line 2 comments Download
M components/devtools_bridge/android/javatests/AndroidManifest.xml View 1 chunk +1 line, -1 line 0 comments Download
M content/shell/android/browsertests_apk/AndroidManifest.xml View 1 chunk +1 line, -1 line 0 comments Download
M content/shell/android/javatests/AndroidManifest.xml View 1 chunk +1 line, -1 line 0 comments Download
M content/shell/android/linker_test_apk/AndroidManifest.xml View 1 chunk +1 line, -1 line 0 comments Download
M content/shell/android/shell_apk/AndroidManifest.xml View 1 chunk +1 line, -1 line 0 comments Download
M mojo/android/javatests/AndroidManifest.xml View 1 chunk +1 line, -1 line 0 comments Download
M mojo/shell/android/apk/AndroidManifest.xml View 1 chunk +1 line, -1 line 0 comments Download
M remoting/android/cast/AndroidManifest.xml.jinja2 View 1 chunk +1 line, -1 line 0 comments Download
M remoting/android/java/AndroidManifest.xml.jinja2 View 1 chunk +1 line, -1 line 0 comments Download
M remoting/android/javatests/AndroidManifest.xml View 1 chunk +1 line, -1 line 0 comments Download
M testing/android/java/AndroidManifest.xml View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (2 generated)
aurimas (slooooooooow)
samuong@chromium.org: Please review changes in chrome/test/chromedriver lambroslambrou@chromium.org: Please review changes in remoting/ aa@chromium.org: Please review ...
6 years, 2 months ago (2014-10-20 20:14:19 UTC) #2
Ted C
lgtm
6 years, 2 months ago (2014-10-20 20:17:05 UTC) #3
boliu
android_webview lgtm And webview is caught up :)
6 years, 2 months ago (2014-10-20 20:27:27 UTC) #4
Lambros
remoting/ lgtm, thanks!
6 years, 2 months ago (2014-10-20 22:03:56 UTC) #5
samuong
On 2014/10/20 22:03:56, Lambros wrote: > remoting/ lgtm, thanks! lgtm for chromedriver/webview_shell
6 years, 2 months ago (2014-10-20 22:26:00 UTC) #6
blundell
//components lgtm https://codereview.chromium.org/664163003/diff/1/components/cronet/android/test/javatests/AndroidManifest.xml File components/cronet/android/test/javatests/AndroidManifest.xml (left): https://codereview.chromium.org/664163003/diff/1/components/cronet/android/test/javatests/AndroidManifest.xml#oldcode17 components/cronet/android/test/javatests/AndroidManifest.xml:17: <uses-sdk android:minSdkVersion="5" android:targetSdkVersion="20" /> why do some ...
6 years, 2 months ago (2014-10-21 05:47:46 UTC) #7
aurimas (slooooooooow)
https://codereview.chromium.org/664163003/diff/1/components/cronet/android/test/javatests/AndroidManifest.xml File components/cronet/android/test/javatests/AndroidManifest.xml (left): https://codereview.chromium.org/664163003/diff/1/components/cronet/android/test/javatests/AndroidManifest.xml#oldcode17 components/cronet/android/test/javatests/AndroidManifest.xml:17: <uses-sdk android:minSdkVersion="5" android:targetSdkVersion="20" /> On 2014/10/21 05:47:46, blundell wrote: ...
6 years, 2 months ago (2014-10-21 16:09:59 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/664163003/1
6 years, 2 months ago (2014-10-21 16:13:16 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-21 17:05:11 UTC) #11
commit-bot: I haz the power
6 years, 2 months ago (2014-10-21 17:06:08 UTC) #12
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/17d3d93913930fa893c668969f1ccd5b4de746cd
Cr-Commit-Position: refs/heads/master@{#300506}

Powered by Google App Engine
This is Rietveld 408576698