components/cronet/android/test/javatests/AndroidManifest.xml - Issue 664163003: Update targetSdkVersion for Chromium applications.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/cronet/android/test/javatests/AndroidManifest.xml

Issue 664163003: Update targetSdkVersion for Chromium applications. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/cronet/android/test/javatests/AndroidManifest.xml

diff --git a/components/cronet/android/test/javatests/AndroidManifest.xml b/components/cronet/android/test/javatests/AndroidManifest.xml

index 47f17b63aacbd755c82343c04162798721562073..d4e9a53e94e6bb6f7f1dbe9a44606345f3e00b1f 100644

--- a/components/cronet/android/test/javatests/AndroidManifest.xml

+++ b/components/cronet/android/test/javatests/AndroidManifest.xml

@@ -14,7 +14,7 @@

<uses-library android:name="android.test.runner" />

</application>

- <uses-sdk android:minSdkVersion="5" android:targetSdkVersion="20" />

blundell 2014/10/21 05:47:46 why do some of these have the min version as 5 and

aurimas (slooooooooow) 2014/10/21 16:09:59 I have no idea. Chrome for Android only supports 1

+ <uses-sdk android:minSdkVersion="5" android:targetSdkVersion="21" />

<instrumentation android:name="android.test.InstrumentationTestRunner"

android:targetPackage="org.chromium.cronet_test_apk"

android:label="Tests for org.chromium.cronet_test_apk"/>