Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(703)

Issue 664153002: Non-SFI Mode: Add disable_nacl_untrusted==0 to the condition of nacl_helper_nonsfi creation. (Closed)

Created:
6 years, 2 months ago by hidehiko
Modified:
6 years, 2 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Non-SFI Mode: Add disable_nacl_untrusted==0 to the condition of nacl_helper_nonsfi creation. nacl_helper_nonsfi is actually NOT the untrusted code, but this is built by the PNaCl toolchain, which is native_client untrusted toolchain in the context of common.gypi. In order to keep the other _nacl.gyp files simple, this CL adds disable_nacl_untrusted==0 guard to the nacl_helper_nonsfi creating condition, so that it does not cause the gyp error due to depending on missing targets when disable_nacl_untrusted is set to 1. BUG=358465 TEST=Ran trybots. Committed: https://crrev.com/0eae344c5c51d5f2375f0ff28793ceba62dd2cde Cr-Commit-Position: refs/heads/master@{#300290}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M components/nacl_nonsfi.gyp View 2 chunks +5 lines, -5 lines 1 comment Download

Messages

Total messages: 7 (2 generated)
hidehiko
Hi, could you take a look? This is the preparation to address Mark's comment of ...
6 years, 2 months ago (2014-10-20 16:40:41 UTC) #2
Mark Seaborn
LGTM
6 years, 2 months ago (2014-10-20 17:06:34 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/664153002/1
6 years, 2 months ago (2014-10-20 17:08:37 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-20 17:30:02 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-10-20 17:30:40 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0eae344c5c51d5f2375f0ff28793ceba62dd2cde
Cr-Commit-Position: refs/heads/master@{#300290}

Powered by Google App Engine
This is Rietveld 408576698