Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(366)

Side by Side Diff: components/nacl_nonsfi.gyp

Issue 664153002: Non-SFI Mode: Add disable_nacl_untrusted==0 to the condition of nacl_helper_nonsfi creation. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 { 5 {
6 'variables': { 6 'variables': {
7 'chromium_code': 1, 7 'chromium_code': 1,
8 }, 8 },
9 'includes': [ 9 'includes': [
10 '../build/common_untrusted.gypi', 10 '../build/common_untrusted.gypi',
11 ], 11 ],
12 'conditions': [ 12 'conditions': [
13 ['disable_nacl==0', { 13 ['disable_nacl==0 and disable_nacl_untrusted==0', {
14 'targets': [ 14 'targets': [
15 { 15 {
16 # Currently, nacl_helper_nonsfi is under development and the binary 16 # Currently, nacl_helper_nonsfi is under development and the binary
17 # does nothing (i.e. it has only empty main(), now). 17 # does nothing (i.e. it has only empty main(), now).
18 # TODO(crbug.com/358465): Implement it then switch nacl_helper in 18 # TODO(crbug.com/358465): Implement it then switch nacl_helper in
19 # Non-SFI mode to nacl_helper_nonsfi. 19 # Non-SFI mode to nacl_helper_nonsfi.
20 'target_name': 'nacl_helper_nonsfi', 20 'target_name': 'nacl_helper_nonsfi',
21 'type': 'none', 21 'type': 'none',
22 'variables': { 22 'variables': {
23 'nacl_untrusted_build': 1, 23 'nacl_untrusted_build': 1,
(...skipping 16 matching lines...) Expand all
40 'conditions': [ 40 'conditions': [
41 ['target_arch=="ia32" or target_arch=="x64"', { 41 ['target_arch=="ia32" or target_arch=="x64"', {
42 'extra_deps_newlib32_nonsfi': [ 42 'extra_deps_newlib32_nonsfi': [
43 '>(tc_lib_dir_nonsfi_helper32)/libbase_nacl_nonsfi.a', 43 '>(tc_lib_dir_nonsfi_helper32)/libbase_nacl_nonsfi.a',
44 '>(tc_lib_dir_nonsfi_helper32)/libevent_nacl_nonsfi.a', 44 '>(tc_lib_dir_nonsfi_helper32)/libevent_nacl_nonsfi.a',
45 ], 45 ],
46 }], 46 }],
47 ], 47 ],
48 }, 48 },
49 'dependencies': [ 49 'dependencies': [
50 '<(DEPTH)/base/base_nacl.gyp:base_nacl_nonsfi', 50 '../base/base_nacl.gyp:base_nacl_nonsfi',
hidehiko 2014/10/20 16:40:41 FYI: this is for standardizing the path in .gyp fi
51 '<(DEPTH)/native_client/src/nonsfi/irt/irt.gyp:nacl_sys_private', 51 '../native_client/src/nonsfi/irt/irt.gyp:nacl_sys_private',
52 '<(DEPTH)/native_client/src/untrusted/nacl/nacl.gyp:nacl_lib_newlib' , 52 '../native_client/src/untrusted/nacl/nacl.gyp:nacl_lib_newlib',
53 '<(DEPTH)/native_client/tools.gyp:prep_toolchain', 53 '../native_client/tools.gyp:prep_toolchain',
54 ], 54 ],
55 }, 55 },
56 # TODO(hidehiko): Add Non-SFI version of nacl_loader_unittests. 56 # TODO(hidehiko): Add Non-SFI version of nacl_loader_unittests.
57 ], 57 ],
58 }], 58 }],
59 ], 59 ],
60 } 60 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698