Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(301)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 664123002: [turbofan] cleanup InstructionSequence (Closed)

Created:
6 years, 2 months ago by dcarney
Modified:
6 years, 2 months ago
Reviewers:
Benedikt Meurer
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

[turbofan] cleanup InstructionSequence R=bmeurer@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=24753

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Total comments: 3

Patch Set 5 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+98 lines, -88 lines) Patch
M src/compiler/arm64/code-generator-arm64.cc View 1 2 3 4 1 chunk +2 lines, -3 lines 0 comments Download
M src/compiler/code-generator.h View 1 2 3 4 2 chunks +7 lines, -4 lines 0 comments Download
M src/compiler/code-generator.cc View 1 chunk +5 lines, -2 lines 0 comments Download
M src/compiler/ia32/code-generator-ia32.cc View 1 2 3 4 1 chunk +2 lines, -3 lines 0 comments Download
M src/compiler/instruction.h View 1 2 3 4 5 chunks +9 lines, -21 lines 0 comments Download
M src/compiler/instruction.cc View 1 2 3 chunks +4 lines, -9 lines 0 comments Download
M src/compiler/instruction-selector.h View 1 2 3 4 3 chunks +7 lines, -6 lines 0 comments Download
M src/compiler/instruction-selector.cc View 1 chunk +3 lines, -1 line 0 comments Download
M src/compiler/pipeline.cc View 3 chunks +6 lines, -4 lines 0 comments Download
M src/compiler/register-allocator.h View 1 2 3 4 3 chunks +9 lines, -2 lines 0 comments Download
M src/compiler/register-allocator.cc View 1 12 chunks +29 lines, -18 lines 0 comments Download
M src/compiler/x64/code-generator-x64.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M test/cctest/compiler/test-codegen-deopt.cc View 3 chunks +6 lines, -5 lines 0 comments Download
M test/cctest/compiler/test-instruction.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M test/unittests/compiler/instruction-selector-unittest.cc View 1 2 2 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
dcarney
ptal
6 years, 2 months ago (2014-10-20 15:33:44 UTC) #2
Benedikt Meurer
LGTM with nits. https://codereview.chromium.org/664123002/diff/60001/src/compiler/code-generator.h File src/compiler/code-generator.h (right): https://codereview.chromium.org/664123002/diff/60001/src/compiler/code-generator.h#newcode120 src/compiler/code-generator.h:120: Frame* frame_; Nit: Frame* const frame_; ...
6 years, 2 months ago (2014-10-21 04:12:04 UTC) #3
dcarney
6 years, 2 months ago (2014-10-21 07:00:07 UTC) #4
Message was sent while issue was closed. 
Committed patchset #5 (id:80001) manually as 24753 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698