Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1200)

Issue 663933003: Remove outdated comment from content_settings_client.h (Closed)

Created:
6 years, 2 months ago by vabr (Chromium)
Modified:
6 years, 2 months ago
Reviewers:
blundell
CC:
chromium-reviews, markusheintz_
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Remove outdated comment from content_settings_client.h The removed comment speaks about StubContentSettingsClient, which was not created in https://codereview.chromium.org/646973002 after all, and thus does not exist in the ToT. This is a comment-only change, thus skipping tests. TBR=blundell@chromium.org NOTRY=true BUG=393248 Committed: https://crrev.com/8e09bf59a7fdc3966b1c9c00426b347d5e1e72ba Cr-Commit-Position: refs/heads/master@{#301077}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -3 lines) Patch
M components/content_settings/core/browser/content_settings_client.h View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
vabr (Chromium)
Hi Colin, This is a follow-up on https://codereview.chromium.org/646973002 -- while I removed the Stub* class ...
6 years, 2 months ago (2014-10-24 09:32:50 UTC) #1
blundell
lgtm
6 years, 2 months ago (2014-10-24 09:33:31 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/663933003/1
6 years, 2 months ago (2014-10-24 09:34:10 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-24 09:34:41 UTC) #5
commit-bot: I haz the power
6 years, 2 months ago (2014-10-24 09:35:23 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8e09bf59a7fdc3966b1c9c00426b347d5e1e72ba
Cr-Commit-Position: refs/heads/master@{#301077}

Powered by Google App Engine
This is Rietveld 408576698