Introduce ChromeContentSettingsClient

Introduce ChromeContentSettingsClient

This CL introduces ChromeContentSettingsClient, the chrome-specific implementation of the content_settings::ContentSettingsClient interface. The CL also adds code to instantiate the implementation with every WebContents.

Left as a TODO for next CLs is actually moving the methods from TabSpecificContentSettings included in the interface to this implementation, they are currently left as stubs.

BUG=393248
Committed: https://crrev.com/6a586eb11ad5e2956516b6da21da360ec6a20e40
Cr-Commit-Position: refs/heads/master@{#299486}

[vabr (Chromium), 2014-10-10 14:39:50]

Patchset #1 (id:1) has been deleted

[vabr (Chromium), 2014-10-10 14:39:58]

Patchset #1 (id:80001) has been deleted

[vabr (Chromium), 2014-10-10 14:40:06]

Patchset #1 (id:140001) has been deleted

[vabr (Chromium), 2014-10-10 14:40:12]

Patchset #1 (id:180001) has been deleted

[vabr (Chromium), 2014-10-10 14:41:10]

Patchset #1 (id:230001) has been deleted

[vabr (Chromium), 2014-10-10 14:42:00]

vabr@chromium.org changed reviewers:
+ blundell@chromium.org

[vabr (Chromium), 2014-10-10 14:42:45]

vabr@chromium.org changed reviewers:
+ markusheintz@chromium.org, pkasting@chromium.org

[vabr (Chromium), 2014-10-10 14:43:21]

vabr@chromium.org changed reviewers:
+ erikwright@chromium.org

[vabr (Chromium), 2014-10-10 14:50:38]

Dear reviewers!

@blundell: Please have a look at the CL as a whole, as this is very
componentisation-specific.

@pkasting: Please review chrome/browser/ui/tab_helpers.cc. Soon,
ChromeContentSettingsClient will replace TabSpecificContentSettings in that
file, but before the relevant methods are moved from TSCS to CCSC, they need to
be there together.

@erikwright: Please check if adding /net/cookies in
components/content_settings/core/browser/DEPS is OK.

@markusheintz: Please rubberstamp the changes to c/b/content_settings.


Thanks a lot!
Vaclav

[Peter Kasting, 2014-10-10 18:04:20]

LGTM

[blundell, 2014-10-13 08:55:58]

LGTM

https://codereview.chromium.org/646973002/diff/390002/chrome/browser/content_...
File chrome/browser/content_settings/chrome_content_settings_client.h (right):

https://codereview.chromium.org/646973002/diff/390002/chrome/browser/content_...
chrome/browser/content_settings/chrome_content_settings_client.h:49: //
depending on |type) local shared objects.
nit: |type|.

https://codereview.chromium.org/646973002/diff/390002/chrome/browser/ui/tab_h...
File chrome/browser/ui/tab_helpers.cc (right):

https://codereview.chromium.org/646973002/diff/390002/chrome/browser/ui/tab_h...
chrome/browser/ui/tab_helpers.cc:154:
TabSpecificContentSettings::CreateForWebContents(web_contents);
TODO with bugref here to get rid of TabSpecificContentSettings entirely?

[vabr (Chromium), 2014-10-13 09:33:17]

Comments addressed so far. Thanks Colin and Peter!

Markus,
Please rubber-stamp c/b/content_settings/* (Colin reviewed the whole patch).

Erik: Please check if adding /net/cookies in
components/content_settings/core/browser/DEPS is OK.

Thanks all!
Vaclav

https://codereview.chromium.org/646973002/diff/390002/chrome/browser/content_...
File chrome/browser/content_settings/chrome_content_settings_client.h (right):

https://codereview.chromium.org/646973002/diff/390002/chrome/browser/content_...
chrome/browser/content_settings/chrome_content_settings_client.h:49: //
depending on |type) local shared objects.
On 2014/10/13 08:55:58, blundell wrote:
> nit: |type|.

Done.

https://codereview.chromium.org/646973002/diff/390002/chrome/browser/ui/tab_h...
File chrome/browser/ui/tab_helpers.cc (right):

https://codereview.chromium.org/646973002/diff/390002/chrome/browser/ui/tab_h...
chrome/browser/ui/tab_helpers.cc:154:
TabSpecificContentSettings::CreateForWebContents(web_contents);
On 2014/10/13 08:55:58, blundell wrote:
> TODO with bugref here to get rid of TabSpecificContentSettings entirely?

Done.

[vabr (Chromium), 2014-10-14 07:53:39]

A friendly ping for Markus and Erik. :)

On 2014/10/13 09:33:17, vabr (Chromium) wrote:
> Comments addressed so far. Thanks Colin and Peter!
> 
> Markus,
> Please rubber-stamp c/b/content_settings/* (Colin reviewed the whole patch).
> 
> Erik: Please check if adding /net/cookies in
> components/content_settings/core/browser/DEPS is OK.
> 
> Thanks all!
> Vaclav

[erikwright (departed), 2014-10-14 14:19:17]

On 2014/10/14 07:53:39, vabr (Chromium) wrote:
> A friendly ping for Markus and Erik. :)
> 
> On 2014/10/13 09:33:17, vabr (Chromium) wrote:
> > Comments addressed so far. Thanks Colin and Peter!
> > 
> > Markus,
> > Please rubber-stamp c/b/content_settings/* (Colin reviewed the whole patch).
> > 
> > Erik: Please check if adding /net/cookies in
> > components/content_settings/core/browser/DEPS is OK.
> > 
> > Thanks all!
> > Vaclav

net/cookies dependency LGTM. Sorry, sick Friday and holiday Monday.

[markusheintz_, 2014-10-14 14:27:32]

On 2014/10/14 14:19:17, erikwright wrote:
> On 2014/10/14 07:53:39, vabr (Chromium) wrote:
> > A friendly ping for Markus and Erik. :)
> > 
> > On 2014/10/13 09:33:17, vabr (Chromium) wrote:
> > > Comments addressed so far. Thanks Colin and Peter!
> > > 
> > > Markus,
> > > Please rubber-stamp c/b/content_settings/* (Colin reviewed the whole
patch).
> > > 
> > > Erik: Please check if adding /net/cookies in
> > > components/content_settings/core/browser/DEPS is OK.
> > > 
> > > Thanks all!
> > > Vaclav
> 
> net/cookies dependency LGTM. Sorry, sick Friday and holiday Monday.

LGTM

[vabr (Chromium), 2014-10-14 14:51:23]

Thanks Markus and Erik!

Sending to the CQ now.

Cheers,
Vaclav

[vabr (Chromium), 2014-10-14 14:51:27]

The CQ bit was checked by vabr@chromium.org

[commit-bot: I haz the power, 2014-10-14 14:52:19]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/646973002/530001

[commit-bot: I haz the power, 2014-10-14 15:06:46]

Committed patchset #3 (id:530001)

[commit-bot: I haz the power, 2014-10-14 15:07:47]

Patchset 3 (id:??) landed as
https://crrev.com/6a586eb11ad5e2956516b6da21da360ec6a20e40
Cr-Commit-Position: refs/heads/master@{#299486}