Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Issue 663903002: net: fix bug in compact HSTS representation. (Closed)

Created:
6 years, 2 months ago by agl
Modified:
6 years, 2 months ago
Reviewers:
palmer
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git/+/master
Project:
chromium
Visibility:
Public.

Description

net: fix bug in compact HSTS representation. In r298580, I added a bug where jumps to the very beginning of the data (bit offset zero) would be rejected. This was found by fuzzing. BUG=none Committed: https://crrev.com/f1fd1df2887acbe72ac107cad49506d430da9ae5 Cr-Commit-Position: refs/heads/master@{#300324}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -3 lines) Patch
M net/http/transport_security_state.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M net/http/transport_security_state_unittest.cc View 2 chunks +23 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
agl
6 years, 2 months ago (2014-10-17 21:59:28 UTC) #2
palmer
lgtm
6 years, 2 months ago (2014-10-17 22:04:16 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/663903002/1
6 years, 2 months ago (2014-10-17 22:06:35 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win_gpu_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered_tests/builds/65025)
6 years, 2 months ago (2014-10-17 22:56:22 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/663903002/1
6 years, 2 months ago (2014-10-20 20:39:05 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-20 20:42:39 UTC) #10
commit-bot: I haz the power
6 years, 2 months ago (2014-10-20 20:43:36 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f1fd1df2887acbe72ac107cad49506d430da9ae5
Cr-Commit-Position: refs/heads/master@{#300324}

Powered by Google App Engine
This is Rietveld 408576698