net: fix bug in compact HSTS representation.

net/http/transport_security_state.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/http/transport_security_state.h"
 
 #if defined(USE_OPENSSL)
 #include <openssl/ecdsa.h>
 #include <openssl/ssl.h>
 #else  // !defined(USE_OPENSSL)
@@ skipping 534 matching lines @@
 
       if (is_first_offset) {
         // The first offset is backwards from the current position.
         uint32 jump_delta_bits;
         uint32 jump_delta;
         if (!reader.Read(5, &jump_delta_bits) ||
             !reader.Read(jump_delta_bits, &jump_delta)) {
           return false;
         }
 
-        if (bit_offset <= jump_delta) {
+        if (bit_offset < jump_delta) {
           return false;
         }
 
         current_offset = bit_offset - jump_delta;
         is_first_offset = false;
       } else {
         // Subsequent offsets are forward from the target of the first offset.
         uint32 is_long_jump;
         if (!reader.Read(1, &is_long_jump)) {
           return false;
@@ skipping 25 matching lines @@
         break;
       }
     }
   }
 }
 
 bool DecodeHSTSPreload(const std::string& hostname,
                        PreloadResult* out) {
   bool found;
   if (!DecodeHSTSPreloadRaw(hostname, &found, out)) {
-    LOG(ERROR) << "Internal error in DecodeHSTSPreloadRaw for hostname "
-               << hostname;
+    DCHECK(false) << "Internal error in DecodeHSTSPreloadRaw for hostname "
+                  << hostname;
     return false;
   }
 
   return found;
 }
 
 bool TransportSecurityState::AddHSTSHeader(const std::string& host,
                                            const std::string& value) {
   DCHECK(CalledOnValidThread());
 
@@ skipping 286 matching lines @@
   return pkp.spki_hashes.size() > 0 || pkp.bad_spki_hashes.size() > 0;
 }
 
 TransportSecurityState::DomainState::PKPState::PKPState() {
 }
 
 TransportSecurityState::DomainState::PKPState::~PKPState() {
 }
 
 }  // namespace