Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(356)

Issue 663813002: Clean up deprecated Web Push API code-paths. (Closed)

Created:
6 years, 2 months ago by Peter Beverloo
Modified:
6 years, 1 month ago
CC:
chromium-reviews, mkwst+moarreviews-renderer_chromium.org, darin-cc_chromium.org, mkwst+moarreviews-shell_chromium.org, jam, jochen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git/+/push-remove-senderId
Project:
chromium
Visibility:
Public.

Description

Clean up deprecated Web Push API code-paths. Remove the Blink API implementations which still accepted a WebString for the sender Id, which is not being used anymore. BUG=424601 Committed: https://crrev.com/28298bf4c9cf9f88660bd73f4576e3f41eac3470 Cr-Commit-Position: refs/heads/master@{#301348}

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -27 lines) Patch
M chrome/test/data/push_messaging/test.html View 1 1 chunk +1 line, -2 lines 0 comments Download
M content/renderer/push_messaging_dispatcher.h View 1 2 chunks +0 lines, -6 lines 0 comments Download
M content/renderer/push_messaging_dispatcher.cc View 1 1 chunk +0 lines, -7 lines 0 comments Download
M content/shell/renderer/test_runner/mock_web_push_client.h View 2 chunks +0 lines, -5 lines 0 comments Download
M content/shell/renderer/test_runner/mock_web_push_client.cc View 1 chunk +0 lines, -7 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
Peter Beverloo
PTAL. This depends on https://codereview.chromium.org/661093002/ and it rolling into Chromium.
6 years, 2 months ago (2014-10-17 14:48:38 UTC) #2
Michael van Ouwerkerk
lgtm
6 years, 2 months ago (2014-10-21 12:51:43 UTC) #3
Peter Beverloo
+sievers for //content stamp. This is the last part of a simple 3-patch cleanup. (1) ...
6 years, 2 months ago (2014-10-24 15:47:04 UTC) #5
no sievers
lgtm
6 years, 2 months ago (2014-10-24 17:57:48 UTC) #6
Peter Beverloo
Blink-side was rolled into Chromium yesterday: https://chromium.googlesource.com/chromium/blink/+log/3e1901b..ff95c8e So putting this on the queue. Thanks for ...
6 years, 1 month ago (2014-10-27 11:35:22 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/663813002/20001
6 years, 1 month ago (2014-10-27 11:36:09 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years, 1 month ago (2014-10-27 12:32:55 UTC) #10
commit-bot: I haz the power
6 years, 1 month ago (2014-10-27 12:33:27 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/28298bf4c9cf9f88660bd73f4576e3f41eac3470
Cr-Commit-Position: refs/heads/master@{#301348}

Powered by Google App Engine
This is Rietveld 408576698