Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1532)

Unified Diff: content/renderer/push_messaging_dispatcher.h

Issue 663813002: Clean up deprecated Web Push API code-paths. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git/+/push-remove-senderId
Patch Set: rebase Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/test/data/push_messaging/test.html ('k') | content/renderer/push_messaging_dispatcher.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/push_messaging_dispatcher.h
diff --git a/content/renderer/push_messaging_dispatcher.h b/content/renderer/push_messaging_dispatcher.h
index de9f8c97a71ab20b93f620597ea5688e0bb0588d..1d6c87dc7930378e7e69399f57b39da7254f43ab 100644
--- a/content/renderer/push_messaging_dispatcher.h
+++ b/content/renderer/push_messaging_dispatcher.h
@@ -20,7 +20,6 @@ class Message;
namespace blink {
class WebServiceWorkerProvider;
-class WebString;
} // namespace blink
namespace content {
@@ -38,11 +37,6 @@ class PushMessagingDispatcher : public RenderFrameObserver,
bool OnMessageReceived(const IPC::Message& message) override;
// WebPushClient implementation.
- // TODO(peter): Remove this signature of registerPushMessaging.
- virtual void registerPushMessaging(
- const blink::WebString& sender_id,
- blink::WebPushRegistrationCallbacks* callbacks,
- blink::WebServiceWorkerProvider* service_worker_provider);
virtual void registerPushMessaging(
blink::WebPushRegistrationCallbacks* callbacks,
blink::WebServiceWorkerProvider* service_worker_provider);
« no previous file with comments | « chrome/test/data/push_messaging/test.html ('k') | content/renderer/push_messaging_dispatcher.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698