Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(349)

Issue 663693005: Use C++11 features in core/timing (Closed)

Created:
6 years, 2 months ago by babu
Modified:
6 years, 2 months ago
Reviewers:
Mike West, Mikhail
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Use C++11 features in core/timing BUG=none Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184161

Patch Set 1 #

Total comments: 2

Patch Set 2 : Addressed review. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -24 lines) Patch
M Source/core/timing/Performance.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/timing/Performance.cpp View 1 5 chunks +15 lines, -12 lines 0 comments Download
M Source/core/timing/PerformanceTiming.cpp View 4 chunks +5 lines, -5 lines 0 comments Download
M Source/core/timing/PerformanceUserTiming.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/timing/PerformanceUserTiming.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/timing/ResourceTimingInfo.h View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
babu
6 years, 2 months ago (2014-10-21 19:07:38 UTC) #2
Mike West
LGTM % nits. https://codereview.chromium.org/663693005/diff/1/Source/core/timing/Performance.cpp File Source/core/timing/Performance.cpp (right): https://codereview.chromium.org/663693005/diff/1/Source/core/timing/Performance.cpp#newcode193 Source/core/timing/Performance.cpp:193: for (const auto& response : redirectChain) ...
6 years, 2 months ago (2014-10-21 19:29:42 UTC) #3
Mikhail
lgtm
6 years, 2 months ago (2014-10-22 06:04:06 UTC) #4
babu
On 2014/10/21 19:29:42, Mike West wrote: > LGTM % nits. > > https://codereview.chromium.org/663693005/diff/1/Source/core/timing/Performance.cpp > File ...
6 years, 2 months ago (2014-10-22 08:30:56 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/663693005/20001
6 years, 2 months ago (2014-10-22 08:34:17 UTC) #7
commit-bot: I haz the power
6 years, 2 months ago (2014-10-22 10:25:31 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as 184161

Powered by Google App Engine
This is Rietveld 408576698