Use C++11 features in core/timing

Use C++11 features in core/timing

BUG=none

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184161

[babu, 2014-10-21 19:05:23]

sudarsana.nagineni@intel.com changed reviewers:
+ mikhail.pozdnyakov@intel.com, mkwst@chromium.org

[Mike West, 2014-10-21 19:29:42]

LGTM % nits.

https://codereview.chromium.org/663693005/diff/1/Source/core/timing/Performan...
File Source/core/timing/Performance.cpp (right):

https://codereview.chromium.org/663693005/diff/1/Source/core/timing/Performan...
Source/core/timing/Performance.cpp:193: for (const auto& response :
redirectChain) {
Nit: Don't use auto here; I think typing ResourceResponse makes this code
clearer.

https://codereview.chromium.org/663693005/diff/1/Source/core/timing/ResourceT...
File Source/core/timing/ResourceTimingInfo.h (right):

https://codereview.chromium.org/663693005/diff/1/Source/core/timing/ResourceT...
Source/core/timing/ResourceTimingInfo.h:70: for (auto& redirect :
m_redirectChain)
Nit: Don't use `auto` here. Using ResourceResponse as the type makes things
clearer.

[Mikhail, 2014-10-22 06:04:06]

lgtm

[babu, 2014-10-22 08:30:56]

On 2014/10/21 19:29:42, Mike West wrote:
> LGTM % nits.
> 
>
https://codereview.chromium.org/663693005/diff/1/Source/core/timing/Performan...
> File Source/core/timing/Performance.cpp (right):
> 
>
https://codereview.chromium.org/663693005/diff/1/Source/core/timing/Performan...
> Source/core/timing/Performance.cpp:193: for (const auto& response :
> redirectChain) {
> Nit: Don't use auto here; I think typing ResourceResponse makes this code
> clearer.

Done.

> 
>
https://codereview.chromium.org/663693005/diff/1/Source/core/timing/ResourceT...
> File Source/core/timing/ResourceTimingInfo.h (right):
> 
>
https://codereview.chromium.org/663693005/diff/1/Source/core/timing/ResourceT...
> Source/core/timing/ResourceTimingInfo.h:70: for (auto& redirect :
> m_redirectChain)
> Nit: Don't use `auto` here. Using ResourceResponse as the type makes things
> clearer.

Done.

[babu, 2014-10-22 08:32:55]

The CQ bit was checked by sudarsana.nagineni@intel.com

[commit-bot: I haz the power, 2014-10-22 08:34:17]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/663693005/20001

[commit-bot: I haz the power, 2014-10-22 10:25:31]

Committed patchset #2 (id:20001) as 184161