Use C++11 features in core/timing

Source/core/timing/Performance.cpp

 /*
  * Copyright (C) 2010 Google Inc. All rights reserved.
  * Copyright (C) 2012 Intel Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
@@ skipping 47 matching lines @@
 }
 
 const AtomicString& Performance::interfaceName() const
 {
     return EventTargetNames::Performance;
 }
 
 ExecutionContext* Performance::executionContext() const
 {
     if (!frame())
-        return 0;
+        return nullptr;
     return frame()->document();
 }
 
 PassRefPtrWillBeRawPtr<MemoryInfo> Performance::memory() const
 {
     return MemoryInfo::create();
 }
 
 PerformanceNavigation* Performance::navigation() const
 {
@@ skipping 23 matching lines @@
     }
 
     std::sort(entries.begin(), entries.end(), PerformanceEntry::startTimeCompareLessThan);
     return entries;
 }
 
 PerformanceEntryVector Performance::getEntriesByType(const String& entryType)
 {
     PerformanceEntryVector entries;
 
-    if (equalIgnoringCase(entryType, "resource"))
-        for (PerformanceEntryVector::const_iterator resource = m_resourceTimingBuffer.begin(); resource != m_resourceTimingBuffer.end(); ++resource)
-            entries.append(*resource);
+    if (equalIgnoringCase(entryType, "resource")) {
+        for (const auto& resource : m_resourceTimingBuffer)
+            entries.append(resource);
+    }
 
     if (m_userTiming) {
         if (equalIgnoringCase(entryType, "mark"))
             entries.appendVector(m_userTiming->getMarks());
         else if (equalIgnoringCase(entryType, "measure"))
             entries.appendVector(m_userTiming->getMeasures());
     }
 
     std::sort(entries.begin(), entries.end(), PerformanceEntry::startTimeCompareLessThan);
     return entries;
 }
 
 PerformanceEntryVector Performance::getEntriesByName(const String& name, const String& entryType)
 {
     PerformanceEntryVector entries;
 
-    if (entryType.isNull() || equalIgnoringCase(entryType, "resource"))
-        for (PerformanceEntryVector::const_iterator resource = m_resourceTimingBuffer.begin(); resource != m_resourceTimingBuffer.end(); ++resource)
-            if ((*resource)->name() == name)
-                entries.append(*resource);
+    if (entryType.isNull() || equalIgnoringCase(entryType, "resource")) {
+        for (const auto& resource : m_resourceTimingBuffer) {
+            if (resource->name() == name)
+                entries.append(resource);
+        }
+    }
 
     if (m_userTiming) {
         if (entryType.isNull() || equalIgnoringCase(entryType, "mark"))
             entries.appendVector(m_userTiming->getMarks(name));
         if (entryType.isNull() || equalIgnoringCase(entryType, "measure"))
             entries.appendVector(m_userTiming->getMeasures(name));
     }
 
     std::sort(entries.begin(), entries.end(), PerformanceEntry::startTimeCompareLessThan);
     return entries;
@@ skipping 22 matching lines @@
     const AtomicString& timingAllowOriginString = originalTimingAllowOrigin.isEmpty() ? response.httpHeaderField(timingAllowOrigin) : originalTimingAllowOrigin;
     if (timingAllowOriginString.isEmpty() || equalIgnoringCase(timingAllowOriginString, "null"))
         return false;
 
     if (timingAllowOriginString == starAtom)
         return true;
 
     const String& securityOrigin = requestingDocument->securityOrigin()->toString();
     Vector<String> timingAllowOrigins;
     timingAllowOriginString.string().split(' ', timingAllowOrigins);
-    for (size_t i = 0; i < timingAllowOrigins.size(); ++i) {
-        if (timingAllowOrigins[i] == securityOrigin)
+    for (const String& allowOrigin : timingAllowOrigins) {
+        if (allowOrigin == securityOrigin)
             return true;
     }
 
     return false;
 }
 
 static bool allowsTimingRedirect(const Vector<ResourceResponse>& redirectChain, const ResourceResponse& finalResponse, Document* initiatorDocument)
 {
     if (!passesTimingAllowCheck(finalResponse, initiatorDocument, emptyAtom))
         return false;
 
-    for (size_t i = 0; i < redirectChain.size(); i++) {
-        if (!passesTimingAllowCheck(redirectChain[i], initiatorDocument, emptyAtom))
+    for (const auto& response : redirectChain) {

[Mike West, 2014/10/21 19:29:42]

Nit: Don't use auto here; I think typing ResourceResponse makes this code
clearer.

+        if (!passesTimingAllowCheck(response, initiatorDocument, emptyAtom))
             return false;
     }
 
     return true;
 }
 
 void Performance::addResourceTiming(const ResourceTimingInfo& info, Document* initiatorDocument)
 {
     if (isResourceTimingBufferFull())
         return;
@@ skipping 76 matching lines @@
 {
     visitor->trace(m_navigation);
     visitor->trace(m_timing);
     visitor->trace(m_resourceTimingBuffer);
     visitor->trace(m_userTiming);
     EventTargetWithInlineData::trace(visitor);
     DOMWindowProperty::trace(visitor);
 }
 
 } // namespace blink