Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 663693003: Place RefPtr for protection not in internalAbort() but in its caller. (Closed)

Created:
6 years, 2 months ago by tyoshino (SeeGerritForStatus)
Modified:
6 years, 2 months ago
Reviewers:
kouhei (in TOK)
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Place RefPtr for protection not in internalAbort() but in its caller. We have RefPtr for preventing XHR from being destroyed in internalAbort(). But we're touching XHR's member variables in the caller of internalAbort(). We must have the RefPtr for protection there. BUG=421504 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183859

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -1 line) Patch
M Source/core/xml/XMLHttpRequest.cpp View 1 7 chunks +16 lines, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
tyoshino (SeeGerritForStatus)
6 years, 2 months ago (2014-10-17 04:23:45 UTC) #2
kouhei (in TOK)
lgtm
6 years, 2 months ago (2014-10-17 04:40:26 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/663693003/20001
6 years, 2 months ago (2014-10-17 04:40:34 UTC) #5
commit-bot: I haz the power
6 years, 2 months ago (2014-10-17 05:43:25 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as 183859

Powered by Google App Engine
This is Rietveld 408576698