Source/web/WebInputEventConversion.h - Issue 663523002: Adding support for DOM3 KeyboardEvents Code in KeyboardEvents

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/WebInputEventConversion.h

Issue 663523002: Adding support for DOM3 KeyboardEvents Code in KeyboardEvents (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Updated unittest to use different urls and destructor to register same url again Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/web/WebInputEventConversion.h

diff --git a/Source/web/WebInputEventConversion.h b/Source/web/WebInputEventConversion.h

index 196b58e82c2d268ee5bcebad2bd5af14dbebc08e..3b5caf58fcd32e814cf3817c55f5db2a915a1de0 100644

--- a/Source/web/WebInputEventConversion.h

+++ b/Source/web/WebInputEventConversion.h

@@ -73,7 +73,7 @@ public:

class PlatformKeyboardEventBuilder : public PlatformKeyboardEvent {

public:

- PlatformKeyboardEventBuilder(const WebKeyboardEvent&);

+ PlatformKeyboardEventBuilder(Widget*, const WebKeyboardEvent&);

void setKeyType(Type);

bool isCharacterKey() const;

};

@@ -120,8 +120,8 @@ public:

// to Undefined.

class WebKeyboardEventBuilder : public WebKeyboardEvent {

public:

- WebKeyboardEventBuilder(const KeyboardEvent&);

- WebKeyboardEventBuilder(const PlatformKeyboardEvent&);

+ WebKeyboardEventBuilder(const Widget*, const KeyboardEvent&);

+ WebKeyboardEventBuilder(const Widget*, const PlatformKeyboardEvent&);

};

// Converts a TouchEvent to a corresponding WebTouchEvent.

« LayoutTests/fast/events/keyboardevent-code.html ('K') | « Source/web/WebInputEvent.cpp ('k') | Source/web/WebInputEventConversion.cpp » ('j') | public/web/WebInputEvent.h » ('J')