Chromium Code Reviews| Index: public/web/WebViewClient.h |
| diff --git a/public/web/WebViewClient.h b/public/web/WebViewClient.h |
| index fa39080f10f3357a060fe897c946eee91b29d73e..29f0fee01e3fe6c404c2f9f6212e577b1ba899c0 100644 |
| --- a/public/web/WebViewClient.h |
| +++ b/public/web/WebViewClient.h |
| @@ -134,6 +134,13 @@ public: |
| // indicating that the default action should be suppressed. |
| virtual bool handleCurrentKeyboardEvent() { return false; } |
| + // This method converts from the embedded-supplied domCode to |
|
bokan
2015/01/20 17:05:59
Nit: embedder-supplied
Habib Virji
2015/01/22 16:01:30
Acknowledged.
|
| + // the string value of the domCode |
|
Wez
2015/01/17 02:35:10
nit: You're missing the full-stop at the line end.
Habib Virji
2015/01/22 16:01:31
Acknowledged.
|
| + virtual const char* domCodeStringFromEnum(long domCode) { return ""; } |
| + |
| + // This method converts from the string converted using above function to |
| + // the dom enum value |
|
Wez
2015/01/17 02:35:10
And you're missing the full-stop here too.
This c
Habib Virji
2015/01/22 16:01:30
Done.
|
| + virtual long domEnumFromCodeString(const char* codeString) { return 0; } |
|
Rick Byers
2015/01/20 14:49:57
We don't pass strings as 'char*' anywhere else in
Habib Virji
2015/01/22 16:01:30
I have changed to WebString.
|
| // Dialogs ------------------------------------------------------------- |