Adding support for DOM3 KeyboardEvents Code in KeyboardEvents

public/web/WebViewClient.h

 /*
  * Copyright (C) 2009 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 116 matching lines @@
 
     // This method is called in response to WebView's handleInputEvent()
     // when the default action for the current keyboard event is not
     // suppressed by the page, to give the embedder a chance to handle
     // the keyboard event specially.
     //
     // Returns true if the keyboard event was handled by the embedder,
     // indicating that the default action should be suppressed.
     virtual bool handleCurrentKeyboardEvent() { return false; }
 
+    // This method converts from the embedded-supplied domCode to

[bokan, 2015/01/20 17:05:59]

Nit: embedder-supplied

[Habib Virji, 2015/01/22 16:01:30]

Acknowledged.

+    // the string value of the domCode

[Wez, 2015/01/17 02:35:10]

nit: You're missing the full-stop at the line end.

[Habib Virji, 2015/01/22 16:01:31]

Acknowledged.

+    virtual const char* domCodeStringFromEnum(long domCode) { return ""; }
+
+    // This method converts from the string converted using above function to
+    // the dom enum value

[Wez, 2015/01/17 02:35:10]

And you're missing the full-stop here too.

This comment is not very clear; you mean it converts from a supplied DOM |code|
string to the embedder's enum value for that key, I think?

[Habib Virji, 2015/01/22 16:01:30]

Done.

+    virtual long domEnumFromCodeString(const char* codeString) { return 0; }

[Rick Byers, 2015/01/20 14:49:57]

We don't pass strings as 'char*' anywhere else in the blink API that I can see
(normally we have UTF16 and questions of lifetime management to address). 
Perhaps we should be using WebString here and above instead?  Or do we want to
keep this as lightweight as possible and require the embedder to simply return
pointers into a static table (no dynamic allocation permitted)?

[Habib Virji, 2015/01/22 16:01:30]

I have changed to WebString. 

 
     // Dialogs -------------------------------------------------------------
 
     // This method returns immediately after showing the dialog. When the
     // dialog is closed, it should call the WebFileChooserCompletion to
     // pass the results of the dialog. Returns false if
     // WebFileChooseCompletion will never be called.
     virtual bool runFileChooser(const WebFileChooserParams&,
                                 WebFileChooserCompletion*) { return false; }
 
@@ skipping 146 matching lines @@
     // Informs the browser that the draggable regions have been updated.
     virtual void draggableRegionsChanged() { }
 
 protected:
     ~WebViewClient() { }
 };
 
 } // namespace blink
 
 #endif