Source/web/WebPopupMenuImpl.cpp - Issue 663523002: Adding support for DOM3 KeyboardEvents Code in KeyboardEvents

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/WebPopupMenuImpl.cpp

Issue 663523002: Adding support for DOM3 KeyboardEvents Code in KeyboardEvents (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Added new embedder API and code review comments update Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/web/WebPopupMenuImpl.cpp

diff --git a/Source/web/WebPopupMenuImpl.cpp b/Source/web/WebPopupMenuImpl.cpp

index f3434ec489e03b1ea0d6667d9d9e7e70baed4716..85e820de56efb62838dd5d8bbcc3eb4485d6a6f9 100644

--- a/Source/web/WebPopupMenuImpl.cpp

+++ b/Source/web/WebPopupMenuImpl.cpp

@@ -159,7 +159,7 @@ bool WebPopupMenuImpl::handleTouchEvent(const WebTouchEvent& event)

bool WebPopupMenuImpl::handleKeyEvent(const WebKeyboardEvent& event)

{

- return m_widget->handleKeyEvent(PlatformKeyboardEventBuilder(event));

+ return m_widget->handleKeyEvent(PlatformKeyboardEventBuilder(m_widget, event));

}

// WebWidget -------------------------------------------------------------------

« Source/web/WebInputEventConversion.cpp ('K') | « Source/web/WebPluginContainerImpl.cpp ('k') | Source/web/WebViewImpl.cpp » ('j') | Source/web/tests/KeyboardTest.cpp » ('J')