Adding support for DOM3 KeyboardEvents Code in KeyboardEvents

Source/web/WebInputEventConversion.cpp

Index: Source/web/WebInputEventConversion.cpp
diff --git a/Source/web/WebInputEventConversion.cpp b/Source/web/WebInputEventConversion.cpp
index 05362ad51cead37f99e912c696d5e67a2e63c626..6d51e6d3acc3c9b0b7a1279e430dddcac75c4aa5 100644
--- a/Source/web/WebInputEventConversion.cpp
+++ b/Source/web/WebInputEventConversion.cpp
@@ -45,6 +45,8 @@
 #include "core/rendering/RenderObject.h"
 #include "platform/KeyboardCodes.h"
 #include "platform/Widget.h"
+#include "public/web/WebViewClient.h"
+#include "web/WebViewImpl.h"
 
 namespace blink {
 
@@ -305,7 +307,28 @@ inline PlatformEvent::Type toPlatformKeyboardEventType(WebInputEvent::Type type)
     return PlatformEvent::KeyDown;
 }
 
-PlatformKeyboardEventBuilder::PlatformKeyboardEventBuilder(const WebKeyboardEvent& e)
+static void getDomCodeStringFromEnum(Widget* widget, String& code, long domCode)

[bokan, 2015/01/20 17:05:58]

Can we return the string, rather than using an output parameter? It'd be
clearer.

[Habib Virji, 2015/01/22 16:01:30]

Done.

+{
+    FrameView* view = toFrameView(widget->root());
+    if (view) {
+        WebViewImpl* webView = WebViewImpl::fromPage(view->page());
+        if (webView)
+            code = webView->client()->domCodeStringFromEnum(domCode);
+    }

[Wez, 2015/01/17 02:35:10]

This leaves the |code| empty, which is also the state it's in if we create a
KeyboardEvent without a code - the DOM UIEvents spec requires unknown codes to
return "Undefined" or something along those lines, IIRC - perhaps check w/
garykac@ what the right thing is to return if there is no |code|, e.g. should
the event just act as though it has no |code| field?

[Habib Virji, 2015/01/22 16:01:30]

I have sent mail to Gary with the questions. 

For timebeing it is done now in two steps:
- If some invalid key is entered: domCodeSringFromEnum, will return "Undefined"
for such keys.
- In case domCodeString cannot execute, it will still return "Undefined" from
Blink. (Though not sure if it's right thing, will amend based on Gary's
comment).

+}
+
+static long getDomEnumFromCodeString(const Widget* widget, const String& code)
+{
+    FrameView* view = toFrameView(widget->root());
+    if (view) {
+        WebViewImpl* webView = WebViewImpl::fromPage(view->page());
+        if (webView)
+            return webView->client()->domEnumFromCodeString(code.utf8().data());
+    }
+    return 0;

[Wez, 2015/01/17 02:35:10]

This means that the embedder cannot use zero as one of the enum values,
otherwise this wouldn't be distinguishable from an actual code; maybe document
that on the domEnumFromCodeString() API interface?

+}
+
+PlatformKeyboardEventBuilder::PlatformKeyboardEventBuilder(Widget* widget, const WebKeyboardEvent& e)
 {
     m_type = toPlatformKeyboardEventType(e.type);
     m_text = String(e.text);
@@ -315,6 +338,7 @@ PlatformKeyboardEventBuilder::PlatformKeyboardEventBuilder(const WebKeyboardEven
     m_nativeVirtualKeyCode = e.nativeKeyCode;
     m_isKeypad = (e.modifiers & WebInputEvent::IsKeyPad);
     m_isSystemKey = e.isSystemKey;
+    getDomCodeStringFromEnum(widget, m_code, e.domCode);
 
     m_modifiers = toPlatformEventModifiers(e.modifiers);
 
@@ -645,7 +669,7 @@ WebMouseWheelEventBuilder::WebMouseWheelEventBuilder(const Widget* widget, const
     canScroll = event.canScroll();
 }
 
-WebKeyboardEventBuilder::WebKeyboardEventBuilder(const KeyboardEvent& event)
+WebKeyboardEventBuilder::WebKeyboardEventBuilder(const Widget* widget, const KeyboardEvent& event)
 {
     if (event.type() == EventTypeNames::keydown)
         type = KeyDown;
@@ -672,6 +696,7 @@ WebKeyboardEventBuilder::WebKeyboardEventBuilder(const KeyboardEvent& event)
     if (!event.keyEvent())
         return;
     nativeKeyCode = event.keyEvent()->nativeVirtualKeyCode();
+    domCode = getDomEnumFromCodeString(widget, event.keyEvent()->code());
     unsigned numberOfCharacters = std::min(event.keyEvent()->text().length(), static_cast<unsigned>(textLengthCap));
     for (unsigned i = 0; i < numberOfCharacters; ++i) {
         text[i] = event.keyEvent()->text()[i];
@@ -696,7 +721,7 @@ WebInputEvent::Type toWebKeyboardEventType(PlatformEvent::Type type)
     }
 }
 
-WebKeyboardEventBuilder::WebKeyboardEventBuilder(const PlatformKeyboardEvent& event)
+WebKeyboardEventBuilder::WebKeyboardEventBuilder(const Widget* widget, const PlatformKeyboardEvent& event)
 {
     type = toWebKeyboardEventType(event.type());
     modifiers = toWebEventModifiers(event.modifiers());
@@ -706,6 +731,7 @@ WebKeyboardEventBuilder::WebKeyboardEventBuilder(const PlatformKeyboardEvent& ev
         modifiers |= WebInputEvent::IsKeyPad;
     isSystemKey = event.isSystemKey();
     nativeKeyCode = event.nativeVirtualKeyCode();
+    domCode = getDomEnumFromCodeString(widget, event.code());
 
     windowsKeyCode = windowsKeyCodeWithoutLocation(event.windowsVirtualKeyCode());
     modifiers |= locationModifiersFromWindowsKeyCode(event.windowsVirtualKeyCode());