Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1632)

Unified Diff: Source/devtools/protocol.json

Issue 663523002: Adding support for DOM3 KeyboardEvents Code in KeyboardEvents (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Updated to use domCode instead of native domCode Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/devtools/protocol.json
diff --git a/Source/devtools/protocol.json b/Source/devtools/protocol.json
index 65cfa6af163d27d7e020151d83bc81e7a27f4fe6..b2f362b12cd9f5633eb32b60cd6b497203cfdf16 100644
--- a/Source/devtools/protocol.json
+++ b/Source/devtools/protocol.json
@@ -4298,6 +4298,7 @@
{ "name": "text", "type": "string", "optional": true, "description": "Text as generated by processing a virtual key code with a keyboard layout. Not needed for for <code>keyUp</code> and <code>rawKeyDown</code> events (default: \"\")" },
{ "name": "unmodifiedText", "type": "string", "optional": true, "description": "Text that would have been generated by the keyboard if no modifiers were pressed (except for shift). Useful for shortcut (accelerator) key handling (default: \"\")." },
{ "name": "keyIdentifier", "type": "string", "optional": true, "description": "Unique key identifier (e.g., 'U+0041') (default: \"\")." },
+ { "name": "code", "type": "integer", "optional": true, "description": "Unique dom code for each physical key (e.g., '0x07002c') (default: 0)." },
Wez 2015/01/08 01:14:47 s/dom/DOM The codes aren't defined by DOM, though
Habib Virji 2015/01/12 15:34:17 Corrected text. Also as you pointed, do not see ne
dgozman 2015/01/12 15:48:16 This is a public method documented at https://deve
Habib Virji 2015/01/12 15:58:19 It can be set by developer. The reason it was up
{ "name": "windowsVirtualKeyCode", "type": "integer", "optional": true, "description": "Windows virtual key code (default: 0)." },
{ "name": "nativeVirtualKeyCode", "type": "integer", "optional": true, "description": "Native virtual key code (default: 0)." },
{ "name": "autoRepeat", "type": "boolean", "optional": true, "description": "Whether the event was generated from auto repeat (default: false)." },

Powered by Google App Engine
This is Rietveld 408576698