Adding support for DOM3 KeyboardEvents Code in KeyboardEvents

Source/devtools/protocol.json

 {
     "version": { "major": "1", "minor": "1" },
     "domains": [{
         "domain": "Inspector",
         "hidden": true,
         "types": [],
         "commands": [
             {
                 "name": "enable",
                 "description": "Enables inspector domain notifications."
@@ skipping 4280 matching lines @@
         "commands": [
             {
                 "name": "dispatchKeyEvent",
                 "parameters": [
                     { "name": "type", "type": "string", "enum": ["keyDown", "keyUp", "rawKeyDown", "char"], "description": "Type of the key event." },
                     { "name": "modifiers", "type": "integer", "optional": true, "description": "Bit field representing pressed modifier keys. Alt=1, Ctrl=2, Meta/Command=4, Shift=8 (default: 0)." },
                     { "name": "timestamp", "type": "number", "optional": true, "description": "Time at which the event occurred. Measured in UTC time in seconds since January 1, 1970 (default: current time)." },
                     { "name": "text", "type": "string", "optional": true, "description": "Text as generated by processing a virtual key code with a keyboard layout. Not needed for for <code>keyUp</code> and <code>rawKeyDown</code> events (default: \"\")" },
                     { "name": "unmodifiedText", "type": "string", "optional": true, "description": "Text that would have been generated by the keyboard if no modifiers were pressed (except for shift). Useful for shortcut (accelerator) key handling (default: \"\")." },
                     { "name": "keyIdentifier", "type": "string", "optional": true, "description": "Unique key identifier (e.g., 'U+0041') (default: \"\")." },
+                    { "name": "code", "type": "integer", "optional": true, "description": "Unique dom code for each physical key (e.g., '0x07002c') (default: 0)." },

[Wez, 2015/01/08 01:14:47]

s/dom/DOM

The codes aren't defined by DOM, though - DOM defines the string values.

If you want this to stay an integer then it's really an opaque value used by the
embedder to represent a DOM |code| value.

[Habib Virji, 2015/01/12 15:34:17]

Corrected text. Also as you pointed, do not see need of using int and using
string instead to represent |code| value.

[dgozman, 2015/01/12 15:48:16]

This is a public method documented at
https://developer.chrome.com/devtools/docs/protocol/1.1/input#command-dispatc....

It should be useful for developers to pass the |code| parameter, otherwise we
should not change public protocol methods.

[Habib Virji, 2015/01/12 15:58:19]

It can be set by developer. 

The reason it was updated, since InspectorInputAgent::dispatchKeyEvent in turns
call PlatformKeyboardEvent.

Since PlatformKeyboardEvent has been updated to handle new domCode string
parameter, it needed to match. 

                     { "name": "windowsVirtualKeyCode", "type": "integer", "optional": true, "description": "Windows virtual key code (default: 0)." },
                     { "name": "nativeVirtualKeyCode", "type": "integer", "optional": true, "description": "Native virtual key code (default: 0)." },
                     { "name": "autoRepeat", "type": "boolean", "optional": true, "description": "Whether the event was generated from auto repeat (default: false)." },
                     { "name": "isKeypad", "type": "boolean", "optional": true, "description": "Whether the event was generated from the keypad (default: false)." },
                     { "name": "isSystemKey", "type": "boolean", "optional": true, "description": "Whether the event was a system key event (default: false)." }
                 ],
                 "description": "Dispatches a key event to the page."
             },
             {
                 "name": "dispatchMouseEvent",
@@ skipping 471 matching lines @@
             {
                 "name": "animationPlayerCreated",
                 "parameters": [
                     { "name": "player", "$ref": "AnimationPlayer", "description": "AnimationPlayer that was created." }
                 ],
                 "hidden": true
             }
         ]
     }]
 }