Issue 663493002: mojo: Fix findbugs issue on java generated code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 663493002: mojo: Fix findbugs issue on java generated code. (Closed)

Created:
6 years, 2 months ago by qsr

Modified:
6 years, 2 months ago

Reviewers:
ppi

CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

More Reviews

Description

mojo: Fix findbugs issue on java generated code. TBR=ppi@chromium.org Committed: https://crrev.com/7a959453b535f357811b89de1ca58cb9131883bb Cr-Commit-Position: refs/heads/master@{#299886}

Patch Set 1 #

Created: 6 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -4 lines)			Patch
	M	mojo/android/javatests/src/org/chromium/mojo/bindings/ValidationTest.java	View		1 chunk	+3 lines, -1 line	0 comments	Download
	M	mojo/public/tools/bindings/generators/java_templates/struct_definition.tmpl	View		3 chunks	+11 lines, -3 lines	0 comments	Download

Messages

Total messages: 5 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/663493002/1

6 years, 2 months ago (2014-10-16 13:15:32 UTC) #3

commit-bot: I haz the power

6 years, 2 months ago (2014-10-16 14:17:47 UTC) #5

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/7a959453b535f357811b89de1ca58cb9131883bb
Cr-Commit-Position: refs/heads/master@{#299886}

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages