Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(746)

Unified Diff: mojo/android/javatests/src/org/chromium/mojo/bindings/ValidationTest.java

Issue 663493002: mojo: Fix findbugs issue on java generated code. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | mojo/public/tools/bindings/generators/java_templates/struct_definition.tmpl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/android/javatests/src/org/chromium/mojo/bindings/ValidationTest.java
diff --git a/mojo/android/javatests/src/org/chromium/mojo/bindings/ValidationTest.java b/mojo/android/javatests/src/org/chromium/mojo/bindings/ValidationTest.java
index d0d63bb17be03d17fbd853935bc65438fad176b7..e6a1923fc570c7d50104dec0f5324ad109a73591 100644
--- a/mojo/android/javatests/src/org/chromium/mojo/bindings/ValidationTest.java
+++ b/mojo/android/javatests/src/org/chromium/mojo/bindings/ValidationTest.java
@@ -97,7 +97,9 @@ public class ValidationTest extends MojoTestCase {
throws FileNotFoundException {
List<TestData> testData = getTestData(prefix);
for (TestData test : testData) {
- assertNull(test.inputData.getErrorMessage());
+ assertNull("Unable to read: " + test.dataFile.getName() +
+ ": " + test.inputData.getErrorMessage(),
+ test.inputData.getErrorMessage());
List<Handle> handles = new ArrayList<Handle>();
for (int i = 0; i < test.inputData.getHandlesCount(); ++i) {
handles.add(new HandleMock());
« no previous file with comments | « no previous file | mojo/public/tools/bindings/generators/java_templates/struct_definition.tmpl » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698