Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Issue 663363004: Use Segoe UI by default for Arabic sans text on Windows (Closed)

Created:
6 years, 2 months ago by ebraminio
Modified:
6 years, 2 months ago
CC:
chromium-reviews, jshin+watch_chromium.org, behdad, Roozbeh
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Use Segoe UI by default for Arabic sans text on Windows BUG=422681 Committed: https://crrev.com/76c65ea684f512493367390b37ea1addca0c1201 Cr-Commit-Position: refs/heads/master@{#300857}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M chrome/app/resources/locale_settings_win.grd View 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/browser/ui/prefs/prefs_tab_helper.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 21 (9 generated)
ebraminio
On 2014/10/21 12:50:47, ebraminio wrote: > mailto:ebraminio@gmail.com changed reviewers: > + mailto:behdad@chromium.org, mailto:eae@chromium.org, mailto:roozbeh@google.com Trybots ...
6 years, 2 months ago (2014-10-21 17:15:48 UTC) #2
eae
+cpu The change itself looks good to me but we'll need to get a chrome/app ...
6 years, 2 months ago (2014-10-21 18:15:58 UTC) #4
cpu_(ooo_6.6-7.5)
lgtm
6 years, 2 months ago (2014-10-21 19:22:08 UTC) #5
eae
ebraminio has signed the CLA. Marking for CQ.
6 years, 2 months ago (2014-10-21 20:06:51 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/663363004/1
6 years, 2 months ago (2014-10-21 20:07:48 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/19049)
6 years, 2 months ago (2014-10-21 20:17:22 UTC) #12
Bernhard Bauer
prefs/ LGTM, but you will need to add your name to the AUTHORS file (see ...
6 years, 2 months ago (2014-10-22 15:29:25 UTC) #15
ebraminio
On 2014/10/22 15:29:25, Bernhard Bauer wrote: > prefs/ LGTM, but you will need to add ...
6 years, 2 months ago (2014-10-22 16:28:54 UTC) #16
ebraminio
All tests passed, please re-put on the CQ. Thank you.
6 years, 2 months ago (2014-10-23 06:41:38 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/663363004/1
6 years, 2 months ago (2014-10-23 08:08:22 UTC) #19
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-23 08:39:35 UTC) #20
commit-bot: I haz the power
6 years, 2 months ago (2014-10-23 09:14:39 UTC) #21
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/76c65ea684f512493367390b37ea1addca0c1201
Cr-Commit-Position: refs/heads/master@{#300857}

Powered by Google App Engine
This is Rietveld 408576698