[chromedriver] Fix tests with viewport; force touch emulation

Fix tests with viewport; force touch emulation

BUG=chromedriver:944
Committed: https://crrev.com/486b72e6575840831b469d771c40f0c554d0a7f4
Cr-Commit-Position: refs/heads/master@{#301016}

[srawlins, 2014-10-23 19:24:19]

srawlins@google.com changed reviewers:
+ samuong@chromium.org

[srawlins, 2014-10-23 19:24:19]

This needs to be synced with master, but then it should fix both the existing
tests, and force touch emulation true.

[srawlins, 2014-10-23 21:05:31]

On 2014/10/23 19:24:19, srawlins wrote:
> This needs to be synced with master, but then it should fix both the existing
> tests, and force touch emulation true.

OK synced. This is a real patch now :)

The viewport is maybe hacky, but it works for now. Unless you have a good
alternative that I can quickly switch over to.

[samuong, 2014-10-23 22:31:46]

I'm still looking over the tests, but the changes to
mobile_emulation_override_manager.cc look good, with one nit.

Also, I forgot to mention this but please also put a "[chromedriver]" at the
start of the issue title, as well as the description.

https://codereview.chromium.org/663343003/diff/40001/chrome/test/chromedriver...
File chrome/test/chromedriver/chrome/mobile_emulation_override_manager.cc
(right):

https://codereview.chromium.org/663343003/diff/40001/chrome/test/chromedriver...
chrome/test/chromedriver/chrome/mobile_emulation_override_manager.cc:80:
"Page.setTouchEmulationEnabled", emulate_touch_params);
nit: you could just change this to "return client_->SendCommand(..." and not
have the separate "Status status(kOk);" declaration on line 47.

[samuong, 2014-10-24 00:16:43]

Also, the BUG= line should look like this: "BUG=chromedriver:944"

[samuong, 2014-10-24 00:29:39]

The CQ bit was checked by samuong@chromium.org

[samuong, 2014-10-24 00:29:40]

lgtm

[commit-bot: I haz the power, 2014-10-24 00:30:25]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/663343003/100001

[commit-bot: I haz the power, 2014-10-24 01:20:15]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2014-10-24 01:21:06]

Patchset 6 (id:??) landed as
https://crrev.com/486b72e6575840831b469d771c40f0c554d0a7f4
Cr-Commit-Position: refs/heads/master@{#301016}