chrome/test/chromedriver/chrome/mobile_emulation_override_manager_unittest.cc - Issue 663343003: [chromedriver] Fix tests with viewport; force touch emulation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/chromedriver/chrome/mobile_emulation_override_manager_unittest.cc

Issue 663343003: [chromedriver] Fix tests with viewport; force touch emulation (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: addressing commetns Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/test/chromedriver/chrome/mobile_emulation_override_manager.cc ('k') | chrome/test/chromedriver/test/run_py_tests.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/test/chromedriver/chrome/mobile_emulation_override_manager_unittest.cc

diff --git a/chrome/test/chromedriver/chrome/mobile_emulation_override_manager_unittest.cc b/chrome/test/chromedriver/chrome/mobile_emulation_override_manager_unittest.cc

index ab9232dfbdf5fd92b570116e45fd779c0a0b6a10..15c9185921d2117c49a54557b60d732f1a3cca77 100644

--- a/chrome/test/chromedriver/chrome/mobile_emulation_override_manager_unittest.cc

+++ b/chrome/test/chromedriver/chrome/mobile_emulation_override_manager_unittest.cc

@@ -89,11 +89,11 @@ TEST(MobileEmulationOverrideManager, SendsCommandOnConnect) {

ASSERT_EQ(0u, client.commands_.size());

ASSERT_EQ(kOk, manager.OnConnected(&client).code());

- ASSERT_EQ(1u, client.commands_.size());

- ASSERT_EQ(kOk, manager.OnConnected(&client).code());

ASSERT_EQ(2u, client.commands_.size());

+ ASSERT_EQ(kOk, manager.OnConnected(&client).code());

+ ASSERT_EQ(4u, client.commands_.size());

ASSERT_NO_FATAL_FAILURE(

- AssertDeviceMetricsCommand(client.commands_[1], device_metrics));

+ AssertDeviceMetricsCommand(client.commands_[2], device_metrics));

}

TEST(MobileEmulationOverrideManager, SendsCommandOnNavigation) {

@@ -107,18 +107,18 @@ TEST(MobileEmulationOverrideManager, SendsCommandOnNavigation) {

ASSERT_EQ(kOk,

manager.OnEvent(&client, "Page.frameNavigated", main_frame_params)

.code());

- ASSERT_EQ(1u, client.commands_.size());

+ ASSERT_EQ(2u, client.commands_.size());

ASSERT_EQ(kOk,

manager.OnEvent(&client, "Page.frameNavigated", main_frame_params)

.code());

- ASSERT_EQ(2u, client.commands_.size());

+ ASSERT_EQ(4u, client.commands_.size());

ASSERT_NO_FATAL_FAILURE(

- AssertDeviceMetricsCommand(client.commands_[1], device_metrics));

+ AssertDeviceMetricsCommand(client.commands_[2], device_metrics));

base::DictionaryValue sub_frame_params;

sub_frame_params.SetString("frame.parentId", "id");

ASSERT_EQ(

kOk,

manager.OnEvent(&client, "Page.frameNavigated", sub_frame_params).code());

- ASSERT_EQ(2u, client.commands_.size());

+ ASSERT_EQ(4u, client.commands_.size());

}