Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(617)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 663083004: [DevTools] Remove remaining usages of global properties. (Closed)

Created:
6 years, 2 months ago by dgozman
Modified:
6 years, 2 months ago
Reviewers:
apavlov, pfeldman
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Project:
blink
Visibility:
Public.

Description

[DevTools] Remove remaining usages of global properties. BUG=424188 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184156

Patch Set 1 #

Total comments: 8

Patch Set 2 : Fixed review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+128 lines, -49 lines) Patch
M Source/devtools/front_end/main/Main.js View 1 4 chunks +14 lines, -10 lines 0 comments Download
M Source/devtools/front_end/timeline/TracingTimelineUIUtils.js View 1 chunk +1 line, -2 lines 0 comments Download
M Source/devtools/front_end/toolbox_bootstrap/Toolbox.js View 2 chunks +3 lines, -2 lines 0 comments Download
M Source/devtools/front_end/ui/ContextMenu.js View 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/ui/DOMExtension.js View 5 chunks +5 lines, -1 line 0 comments Download
M Source/devtools/front_end/ui/Dialog.js View 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/ui/PieChart.js View 1 1 chunk +1 line, -0 lines 0 comments Download
M Source/devtools/front_end/ui/Popover.js View 1 2 chunks +4 lines, -1 line 0 comments Download
M Source/devtools/front_end/ui/RootView.js View 1 2 chunks +6 lines, -0 lines 0 comments Download
M Source/devtools/front_end/ui/ShortcutRegistry.js View 2 chunks +7 lines, -3 lines 0 comments Download
M Source/devtools/front_end/ui/SoftContextMenu.js View 3 chunks +5 lines, -3 lines 0 comments Download
M Source/devtools/front_end/ui/StatusBarButton.js View 1 chunk +2 lines, -1 line 0 comments Download
M Source/devtools/front_end/ui/SuggestBox.js View 1 4 chunks +9 lines, -1 line 0 comments Download
M Source/devtools/front_end/ui/TextPrompt.js View 7 chunks +15 lines, -6 lines 0 comments Download
M Source/devtools/front_end/ui/UIUtils.js View 1 10 chunks +48 lines, -14 lines 0 comments Download
M Source/devtools/front_end/ui/View.js View 1 3 chunks +3 lines, -2 lines 0 comments Download
M Source/devtools/front_end/ui/ViewportControl.js View 1 chunk +1 line, -0 lines 0 comments Download
M Source/devtools/front_end/ui/ZoomManager.js View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
dgozman
Take a look please.
6 years, 2 months ago (2014-10-21 14:36:30 UTC) #2
apavlov
lgtm with comments https://codereview.chromium.org/663083004/diff/1/Source/devtools/front_end/timeline/TracingTimelineUIUtils.js File Source/devtools/front_end/timeline/TracingTimelineUIUtils.js (right): https://codereview.chromium.org/663083004/diff/1/Source/devtools/front_end/timeline/TracingTimelineUIUtils.js#newcode796 Source/devtools/front_end/timeline/TracingTimelineUIUtils.js:796: var detailsNode = createElementWithClass("div", "timeline-details-view-row"); unrelated? ...
6 years, 2 months ago (2014-10-21 15:15:38 UTC) #3
dgozman
https://codereview.chromium.org/663083004/diff/1/Source/devtools/front_end/timeline/TracingTimelineUIUtils.js File Source/devtools/front_end/timeline/TracingTimelineUIUtils.js (right): https://codereview.chromium.org/663083004/diff/1/Source/devtools/front_end/timeline/TracingTimelineUIUtils.js#newcode796 Source/devtools/front_end/timeline/TracingTimelineUIUtils.js:796: var detailsNode = createElementWithClass("div", "timeline-details-view-row"); On 2014/10/21 15:15:38, apavlov ...
6 years, 2 months ago (2014-10-22 08:04:03 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/663083004/20001
6 years, 2 months ago (2014-10-22 08:04:51 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-10-22 09:12:51 UTC) #7
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as 184156

Powered by Google App Engine
This is Rietveld 408576698