Source/devtools/front_end/ui/StatusBarButton.js - Issue 663083004: [DevTools] Remove remaining usages of global properties.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/devtools/front_end/ui/StatusBarButton.js

Issue 663083004: [DevTools] Remove remaining usages of global properties. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Fixed review comments Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/devtools/front_end/ui/StatusBarButton.js

diff --git a/Source/devtools/front_end/ui/StatusBarButton.js b/Source/devtools/front_end/ui/StatusBarButton.js

index 8ff07f716b94db14bd5029a032df1b7e7d51c21e..0e86f5a737a7d385fe86c7a0c8c18612255f48b5 100644

--- a/Source/devtools/front_end/ui/StatusBarButton.js

+++ b/Source/devtools/front_end/ui/StatusBarButton.js

@@ -398,9 +398,10 @@ WebInspector.StatusBarButtonBase.prototype = {

mainButtonClone.state = this.state;

buttons.push(mainButtonClone);

+ var document = this.element.ownerDocument;

document.documentElement.addEventListener("mouseup", mouseUp, false);

- var optionsGlassPane = new WebInspector.GlassPane();

+ var optionsGlassPane = new WebInspector.GlassPane(document);

var optionsBarElement = optionsGlassPane.element.createChild("div", "alternate-status-bar-buttons-bar");

const buttonHeight = 23;