Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Issue 663033003: Correcting -expected.png files generated after rebaseline. (Closed)

Created:
6 years, 2 months ago by Ambarish
Modified:
6 years, 2 months ago
CC:
blink-reviews, Xianzhu
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Correcting -expected.png files generated after rebaseline. These tests were initialy rebaselined as a part of, https://codereview.chromium.org/568453002/ The -expected.png files generated for Win-XP, as a part of rebaseline are upside down. Please refer here, https://codereview.chromium.org/662683004/ The original change should not cause this flanky behavior of tests. It may be due to flanky behavior of build bot. So requesting rebaseline for these tests again. BUG=425157 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184102

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M LayoutTests/TestExpectations View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Ambarish
Dear All, This is a request for rebaselining few tests which generated upside down -expected.png ...
6 years, 2 months ago (2014-10-21 10:08:41 UTC) #2
Xianzhu
lgtm. For other reviewers' information: crbug.com/425172 is about the upside-down image issue. Related question: how ...
6 years, 2 months ago (2014-10-21 15:52:59 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/663033003/1
6 years, 2 months ago (2014-10-21 15:53:14 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-10-21 17:34:12 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 184102

Powered by Google App Engine
This is Rietveld 408576698