Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Issue 662683004: Auto-rebaseline for r183917 (Closed)

Created:
6 years, 2 months ago by Xianzhu
Modified:
6 years, 2 months ago
Reviewers:
Ambarish
CC:
blink-reviews
Project:
blink
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -39 lines) Patch
M LayoutTests/TestExpectations View 1 chunk +0 lines, -13 lines 0 comments Download
A + LayoutTests/platform/android/editing/input/caret-at-the-edge-of-contenteditable-expected.png View Binary file 0 comments Download
A + LayoutTests/platform/android/editing/input/reveal-caret-of-multiline-contenteditable-expected.png View Binary file 0 comments Download
A + LayoutTests/platform/android/editing/input/reveal-caret-of-multiline-input-expected.png View Binary file 0 comments Download
A + LayoutTests/platform/android/fast/forms/listbox-hit-test-zoomed-expected.png View Binary file 0 comments Download
A + LayoutTests/platform/android/fast/forms/select/menulist-appearance-basic-expected.png View Binary file 0 comments Download
A + LayoutTests/platform/android/fast/forms/suggestion-picker/date-suggestion-picker-appearance-with-scroll-bar-expected.png View Binary file 0 comments Download
A + LayoutTests/platform/android/fast/forms/suggestion-picker/month-suggestion-picker-appearance-with-scroll-bar-expected.png View Binary file 0 comments Download
A + LayoutTests/platform/android/fast/forms/suggestion-picker/week-suggestion-picker-appearance-with-scroll-bar-expected.png View Binary file 0 comments Download
M LayoutTests/platform/linux/editing/input/caret-at-the-edge-of-contenteditable-expected.png View Binary file 0 comments Download
M LayoutTests/platform/linux/editing/input/caret-at-the-edge-of-contenteditable-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/platform/linux/editing/input/reveal-caret-of-multiline-contenteditable-expected.png View Binary file 0 comments Download
M LayoutTests/platform/linux/editing/input/reveal-caret-of-multiline-contenteditable-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/platform/linux/editing/input/reveal-caret-of-multiline-input-expected.png View Binary file 0 comments Download
M LayoutTests/platform/linux/editing/input/reveal-caret-of-multiline-input-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/platform/linux/fast/forms/listbox-hit-test-zoomed-expected.png View Binary file 0 comments Download
M LayoutTests/platform/linux/fast/forms/select-initial-position-expected.png View Binary file 0 comments Download
M LayoutTests/platform/linux/fast/forms/select-initial-position-expected.txt View 2 chunks +2 lines, -2 lines 0 comments Download
M LayoutTests/platform/linux/fast/forms/select/menulist-appearance-basic-expected.png View Binary file 0 comments Download
M LayoutTests/platform/linux/fast/forms/select/menulist-appearance-basic-expected.txt View 2 chunks +2 lines, -2 lines 0 comments Download
M LayoutTests/platform/linux/fast/forms/suggestion-picker/date-suggestion-picker-appearance-with-scroll-bar-expected.png View Binary file 0 comments Download
M LayoutTests/platform/linux/fast/forms/suggestion-picker/month-suggestion-picker-appearance-with-scroll-bar-expected.png View Binary file 0 comments Download
M LayoutTests/platform/linux/fast/forms/suggestion-picker/week-suggestion-picker-appearance-with-scroll-bar-expected.png View Binary file 0 comments Download
M LayoutTests/platform/mac-lion/editing/input/reveal-caret-of-multiline-contenteditable-expected.png View Binary file 0 comments Download
M LayoutTests/platform/mac-lion/editing/input/reveal-caret-of-multiline-input-expected.png View Binary file 0 comments Download
M LayoutTests/platform/mac-lion/fast/forms/listbox-hit-test-zoomed-expected.png View Binary file 0 comments Download
M LayoutTests/platform/mac-lion/fast/forms/select-initial-position-expected.png View Binary file 0 comments Download
M LayoutTests/platform/mac-lion/fast/forms/select/menulist-appearance-basic-expected.png View Binary file 0 comments Download
M LayoutTests/platform/mac-lion/fast/forms/suggestion-picker/date-suggestion-picker-appearance-with-scroll-bar-expected.png View Binary file 0 comments Download
M LayoutTests/platform/mac-lion/fast/forms/suggestion-picker/month-suggestion-picker-appearance-with-scroll-bar-expected.png View Binary file 0 comments Download
M LayoutTests/platform/mac-lion/fast/forms/suggestion-picker/week-suggestion-picker-appearance-with-scroll-bar-expected.png View Binary file 0 comments Download
M LayoutTests/platform/mac-mountainlion/editing/input/reveal-caret-of-multiline-contenteditable-expected.png View Binary file 0 comments Download
M LayoutTests/platform/mac-mountainlion/editing/input/reveal-caret-of-multiline-input-expected.png View Binary file 0 comments Download
M LayoutTests/platform/mac-mountainlion/fast/forms/listbox-hit-test-zoomed-expected.png View Binary file 0 comments Download
M LayoutTests/platform/mac-mountainlion/fast/forms/select-initial-position-expected.png View Binary file 0 comments Download
M LayoutTests/platform/mac-mountainlion/fast/forms/select/menulist-appearance-basic-expected.png View Binary file 0 comments Download
M LayoutTests/platform/mac-mountainlion/fast/forms/suggestion-picker/date-suggestion-picker-appearance-with-scroll-bar-expected.png View Binary file 0 comments Download
M LayoutTests/platform/mac-mountainlion/fast/forms/suggestion-picker/month-suggestion-picker-appearance-with-scroll-bar-expected.png View Binary file 0 comments Download
M LayoutTests/platform/mac-mountainlion/fast/forms/suggestion-picker/week-suggestion-picker-appearance-with-scroll-bar-expected.png View Binary file 0 comments Download
M LayoutTests/platform/mac-snowleopard/editing/input/reveal-caret-of-multiline-contenteditable-expected.png View Binary file 0 comments Download
M LayoutTests/platform/mac-snowleopard/editing/input/reveal-caret-of-multiline-input-expected.png View Binary file 0 comments Download
M LayoutTests/platform/mac-snowleopard/fast/forms/listbox-hit-test-zoomed-expected.png View Binary file 0 comments Download
M LayoutTests/platform/mac-snowleopard/fast/forms/select-initial-position-expected.png View Binary file 0 comments Download
M LayoutTests/platform/mac-snowleopard/fast/forms/select/menulist-appearance-basic-expected.png View Binary file 0 comments Download
M LayoutTests/platform/mac-snowleopard/fast/forms/suggestion-picker/date-suggestion-picker-appearance-with-scroll-bar-expected.png View Binary file 0 comments Download
M LayoutTests/platform/mac-snowleopard/fast/forms/suggestion-picker/month-suggestion-picker-appearance-with-scroll-bar-expected.png View Binary file 0 comments Download
M LayoutTests/platform/mac-snowleopard/fast/forms/suggestion-picker/week-suggestion-picker-appearance-with-scroll-bar-expected.png View Binary file 0 comments Download
M LayoutTests/platform/mac/editing/input/caret-at-the-edge-of-contenteditable-expected.png View Binary file 0 comments Download
M LayoutTests/platform/mac/editing/input/caret-at-the-edge-of-contenteditable-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/platform/mac/editing/input/reveal-caret-of-multiline-contenteditable-expected.png View Binary file 0 comments Download
M LayoutTests/platform/mac/editing/input/reveal-caret-of-multiline-contenteditable-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/platform/mac/editing/input/reveal-caret-of-multiline-input-expected.png View Binary file 0 comments Download
M LayoutTests/platform/mac/editing/input/reveal-caret-of-multiline-input-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/platform/mac/fast/forms/listbox-hit-test-zoomed-expected.png View Binary file 0 comments Download
M LayoutTests/platform/mac/fast/forms/listbox-hit-test-zoomed-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/platform/mac/fast/forms/select-initial-position-expected.png View Binary file 0 comments Download
M LayoutTests/platform/mac/fast/forms/select-initial-position-expected.txt View 2 chunks +2 lines, -2 lines 0 comments Download
M LayoutTests/platform/mac/fast/forms/select/menulist-appearance-basic-expected.png View Binary file 0 comments Download
M LayoutTests/platform/mac/fast/forms/select/menulist-appearance-basic-expected.txt View 2 chunks +2 lines, -2 lines 0 comments Download
M LayoutTests/platform/mac/fast/forms/suggestion-picker/date-suggestion-picker-appearance-with-scroll-bar-expected.png View Binary file 0 comments Download
M LayoutTests/platform/mac/fast/forms/suggestion-picker/month-suggestion-picker-appearance-with-scroll-bar-expected.png View Binary file 0 comments Download
M LayoutTests/platform/mac/fast/forms/suggestion-picker/week-suggestion-picker-appearance-with-scroll-bar-expected.png View Binary file 0 comments Download
M LayoutTests/platform/win-xp/editing/input/caret-at-the-edge-of-contenteditable-expected.png View Binary file 0 comments Download
M LayoutTests/platform/win-xp/editing/input/caret-at-the-edge-of-contenteditable-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/platform/win-xp/editing/input/reveal-caret-of-multiline-contenteditable-expected.png View Binary file 0 comments Download
M LayoutTests/platform/win-xp/editing/input/reveal-caret-of-multiline-contenteditable-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/platform/win-xp/editing/input/reveal-caret-of-multiline-input-expected.png View Binary file 0 comments Download
M LayoutTests/platform/win-xp/editing/input/reveal-caret-of-multiline-input-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/platform/win-xp/fast/forms/listbox-hit-test-zoomed-expected.png View Binary file 0 comments Download
M LayoutTests/platform/win-xp/fast/forms/select-initial-position-expected.png View Binary file 0 comments Download
M LayoutTests/platform/win-xp/fast/forms/select/menulist-appearance-basic-expected.png View Binary file 0 comments Download
A LayoutTests/platform/win-xp/fast/forms/suggestion-picker/date-suggestion-picker-appearance-with-scroll-bar-expected.png View Binary file 0 comments Download
A LayoutTests/platform/win-xp/fast/forms/suggestion-picker/month-suggestion-picker-appearance-with-scroll-bar-expected.png View Binary file 0 comments Download
A LayoutTests/platform/win-xp/fast/forms/suggestion-picker/week-suggestion-picker-appearance-with-scroll-bar-expected.png View Binary file 0 comments Download
M LayoutTests/platform/win/editing/input/caret-at-the-edge-of-contenteditable-expected.png View Binary file 0 comments Download
M LayoutTests/platform/win/editing/input/caret-at-the-edge-of-contenteditable-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/platform/win/editing/input/reveal-caret-of-multiline-contenteditable-expected.png View Binary file 0 comments Download
M LayoutTests/platform/win/editing/input/reveal-caret-of-multiline-contenteditable-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/platform/win/editing/input/reveal-caret-of-multiline-input-expected.png View Binary file 0 comments Download
M LayoutTests/platform/win/editing/input/reveal-caret-of-multiline-input-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/platform/win/fast/forms/listbox-hit-test-zoomed-expected.png View Binary file 0 comments Download
M LayoutTests/platform/win/fast/forms/listbox-hit-test-zoomed-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/platform/win/fast/forms/select-initial-position-expected.png View Binary file 0 comments Download
M LayoutTests/platform/win/fast/forms/select-initial-position-expected.txt View 2 chunks +2 lines, -2 lines 0 comments Download
M LayoutTests/platform/win/fast/forms/select/menulist-appearance-basic-expected.png View Binary file 0 comments Download
M LayoutTests/platform/win/fast/forms/select/menulist-appearance-basic-expected.txt View 2 chunks +2 lines, -2 lines 0 comments Download
M LayoutTests/platform/win/fast/forms/suggestion-picker/date-suggestion-picker-appearance-with-scroll-bar-expected.png View Binary file 0 comments Download
M LayoutTests/platform/win/fast/forms/suggestion-picker/month-suggestion-picker-appearance-with-scroll-bar-expected.png View Binary file 0 comments Download
M LayoutTests/platform/win/fast/forms/suggestion-picker/week-suggestion-picker-appearance-with-scroll-bar-expected.png View Binary file 0 comments Download

Messages

Total messages: 3 (0 generated)
Xianzhu
Committed patchset #1 (id:1) manually as 183927 (presubmit successful).
6 years, 2 months ago (2014-10-17 21:36:54 UTC) #1
Ambarish
Hi, Below Win-XP test images(4) are upside down, Is this expected ? LayoutTests/platform/win-xp/fast/forms/select/menulist-appearance-basic-expected.png LayoutTests/platform/win-xp/fast/forms/suggestion-picker/date-suggestion-picker-appearance-with-scroll-bar-expected.png LayoutTests/platform/win-xp/fast/forms/suggestion-picker/month-suggestion-picker-appearance-with-scroll-bar-expected.png ...
6 years, 2 months ago (2014-10-20 14:25:02 UTC) #2
Xianzhu
6 years, 2 months ago (2014-10-20 15:57:07 UTC) #3
Message was sent while issue was closed.
On 2014/10/20 14:25:02, Ambarish wrote:
> Hi,
> Below Win-XP test images(4) are upside down,
> Is this expected ?
> 
> 
>
LayoutTests/platform/win-xp/fast/forms/select/menulist-appearance-basic-expected.png
> 
>
LayoutTests/platform/win-xp/fast/forms/suggestion-picker/date-suggestion-picker-appearance-with-scroll-bar-expected.png
> 
>
LayoutTests/platform/win-xp/fast/forms/suggestion-picker/month-suggestion-picker-appearance-with-scroll-bar-expected.png
> 
>
LayoutTests/platform/win-xp/fast/forms/suggestion-picker/week-suggestion-picker-appearance-with-scroll-bar-expected.png

I'm volunteering to run the rebaseline-o-matic script which pulls actual layout
test result from the build bots. The above results seem incorrect, perhaps
because of flakiness of the build bots. You can mark them NeedsRebaseline again
with [ WinXP ]. Perhaps the sheriff will also file a bug if the rebaseline
results cause failure in later bot builds, so you might want to contact the
sheriff about the incorrect results.

Powered by Google App Engine
This is Rietveld 408576698