Enables goma from GYP.

This is for enabling goma from GYP side. It also enables goma if the user set
GOMA_DIR environmental variable.

As you may know, I am working on making nacl-gcc/g++ compile treated by goma on
Windows. Then, nacl-gcc/goma need to be executed in the manner the user use goma
on Windows.

I believe this is the way.

Description:
Enables goma from GYP.

Currently goma is automatically used if gomacc is included in the PATH.
However, if the developers use goma in "gomacc <compiler name>" style, we
recommend not to include goma directory in the PATH.

I am re-implementing following change and works with this change:
https://codereview.chromium.org/12419003/
It adds gomadir GYP_DEFINES for ease of goma configuration.

[Yoshisato Yanagisawa, 2013-11-11 22:59:30]

Hi all,

This is for enabling goma from GYP side. It also enables goma if the user set
GOMA_DIR environmental variable.

As you may know, I am working on making nacl-gcc/g++ compile treated by goma on
Windows. Then, nacl-gcc/goma need to be executed in the manner the user use goma
on Windows.

I believe this is the way.

[Yoshisato Yanagisawa, 2013-11-12 22:21:21]

Do you see any issues on this?

[bradn, 2013-11-12 22:32:56]

lgtm

https://codereview.chromium.org/66303010/diff/320001/build/build_nexe.py
File build/build_nexe.py (right):

https://codereview.chromium.org/66303010/diff/320001/build/build_nexe.py#newc...
build/build_nexe.py:105: if (osname not in ['linux']
why this change?

https://codereview.chromium.org/66303010/diff/320001/build/build_nexe.py#newc...
build/build_nexe.py:119: # Use gomadir in the command argument.
Maybe make clear that the command line trumps the environment?

[Yoshisato Yanagisawa, 2013-11-12 23:01:23]

Thanks for the review.

https://codereview.chromium.org/66303010/diff/320001/build/build_nexe.py
File build/build_nexe.py (right):

https://codereview.chromium.org/66303010/diff/320001/build/build_nexe.py#newc...
build/build_nexe.py:105: if (osname not in ['linux']
On 2013/11/12 22:32:56, bradn wrote:
> why this change?

For ease of adding new OS but I understand one change list should usually have
one goal.
I will make another change list for adding new os.

https://codereview.chromium.org/66303010/diff/320001/build/build_nexe.py#newc...
build/build_nexe.py:119: # Use gomadir in the command argument.
On 2013/11/12 22:32:56, bradn wrote:
> Maybe make clear that the command line trumps the environment?

Done.

[bradn, 2013-11-12 23:02:05]

lgtm

[commit-bot: I haz the power, 2013-11-13 22:02:29]

CQ is trying da patch. Follow status at
https://nativeclient-status.appspot.com/cq/yyanagisawa@chromium.org/66303010/...

[Sam Clegg, 2013-11-13 22:20:22]

lgtm

https://codereview.chromium.org/66303010/diff/560001/build/build_nexe.py
File build/build_nexe.py (right):

https://codereview.chromium.org/66303010/diff/560001/build/build_nexe.py#newc...
build/build_nexe.py:107: or os.environ.get('NO_NACL_GOMA', None)):
second arg of get() defaults to none so can be omitted.

https://codereview.chromium.org/66303010/diff/560001/build/build_nexe.py#newc...
build/build_nexe.py:120: goma_dir_env = os.environ.get('GOMA_DIR', None)
Remove 'None'.

https://codereview.chromium.org/66303010/diff/560001/build/build_nexe.py#newc...
build/build_nexe.py:124: path_env = os.environ.get('PATH', None)
Remove 'None'

[Yoshisato Yanagisawa, 2013-11-13 22:26:05]

Thanks for the review.

https://codereview.chromium.org/66303010/diff/560001/build/build_nexe.py
File build/build_nexe.py (right):

https://codereview.chromium.org/66303010/diff/560001/build/build_nexe.py#newc...
build/build_nexe.py:107: or os.environ.get('NO_NACL_GOMA', None)):
On 2013/11/13 22:20:23, Sam Clegg wrote:
> second arg of get() defaults to none so can be omitted.

Done.

https://codereview.chromium.org/66303010/diff/560001/build/build_nexe.py#newc...
build/build_nexe.py:120: goma_dir_env = os.environ.get('GOMA_DIR', None)
On 2013/11/13 22:20:23, Sam Clegg wrote:
> Remove 'None'.

Done.

https://codereview.chromium.org/66303010/diff/560001/build/build_nexe.py#newc...
build/build_nexe.py:124: path_env = os.environ.get('PATH', None)
On 2013/11/13 22:20:23, Sam Clegg wrote:
> Remove 'None'

Done.

[commit-bot: I haz the power, 2013-11-13 22:42:05]

CQ is trying da patch. Follow status at
https://nativeclient-status.appspot.com/cq/yyanagisawa@chromium.org/66303010/...

[commit-bot: I haz the power, 2013-11-14 01:16:26]

Change committed as 12387

[Mark Seaborn, 2013-11-14 23:47:25]

This change appears to break when rolled into Chromium's nacl_revision:

Updating projects from gyp files...
gyp: name 'goma_status' is not defined while evaluating condition
'goma_status!="ok"' in
/mnt/scratch0/b_used/build/slave/linux/build/src/components/nacl.gyp
gyp: name 'goma_status' is not defined while evaluating condition
'goma_status!="ok"' in
/mnt/scratch0/b_used/build/slave/linux/build/src/ppapi/ppapi_untrusted.gyp
gyp: name 'goma_status' is not defined while evaluating condition
'goma_status!="ok"' in
/mnt/scratch0/b_used/build/slave/linux/build/src/ppapi/tests/extensions/extensions.gyp
...

This error is from
http://build.chromium.org/p/tryserver.chromium/builders/linux_rel/builds/1899...

See https://codereview.chromium.org/71693004/

[Yoshisato Yanagisawa, 2013-11-14 23:51:25]

This is my fault.
This is affected by the .gyp rule change with my commit.

Is it OK if I fix it right now?
Or, you are in hurry, please just remove my change.

Sorry for inconvenience.


2013/11/15 <mseaborn@chromium.org>

> This change appears to break when rolled into Chromium's nacl_revision:
>
> Updating projects from gyp files...
> gyp: name 'goma_status' is not defined while evaluating condition
> 'goma_status!="ok"' in
> /mnt/scratch0/b_used/build/slave/linux/build/src/components/nacl.gyp
> gyp: name 'goma_status' is not defined while evaluating condition
> 'goma_status!="ok"' in
> /mnt/scratch0/b_used/build/slave/linux/build/src/ppapi/ppapi_untrusted.gyp
> gyp: name 'goma_status' is not defined while evaluating condition
> 'goma_status!="ok"' in
> /mnt/scratch0/b_used/build/slave/linux/build/src/ppapi/
> tests/extensions/extensions.gyp
> ...
>
> This error is from
> http://build.chromium.org/p/tryserver.chromium/builders/
> linux_rel/builds/189929/steps/runhooks/logs/stdio
>
> See https://codereview.chromium.org/71693004/
>
> https://codereview.chromium.org/66303010/
>

-- 
You received this message because you are subscribed to the Google Groups
"Native-Client-Reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to native-client-reviews+unsubscribe@googlegroups.com.
To post to this group, send email to native-client-reviews@googlegroups.com.
Visit this group at http://groups.google.com/group/native-client-reviews.
For more options, visit https://groups.google.com/groups/opt_out.

[Yoshisato Yanagisawa, 2013-11-15 00:19:51]

This is the change:
https://codereview.chromium.org/64433003/

Just revert untrsuted.gypi


2013/11/15 Yoshisato Yanagisawa <yyanagisawa@chromium.org>

> This is my fault.
> This is affected by the .gyp rule change with my commit.
>
> Is it OK if I fix it right now?
> Or, you are in hurry, please just remove my change.
>
> Sorry for inconvenience.
>
>
> 2013/11/15 <mseaborn@chromium.org>
>
> This change appears to break when rolled into Chromium's nacl_revision:
>>
>> Updating projects from gyp files...
>> gyp: name 'goma_status' is not defined while evaluating condition
>> 'goma_status!="ok"' in
>> /mnt/scratch0/b_used/build/slave/linux/build/src/components/nacl.gyp
>> gyp: name 'goma_status' is not defined while evaluating condition
>> 'goma_status!="ok"' in
>> /mnt/scratch0/b_used/build/slave/linux/build/src/ppapi/
>> ppapi_untrusted.gyp
>> gyp: name 'goma_status' is not defined while evaluating condition
>> 'goma_status!="ok"' in
>> /mnt/scratch0/b_used/build/slave/linux/build/src/ppapi/
>> tests/extensions/extensions.gyp
>> ...
>>
>> This error is from
>> http://build.chromium.org/p/tryserver.chromium/builders/
>> linux_rel/builds/189929/steps/runhooks/logs/stdio
>>
>> See https://codereview.chromium.org/71693004/
>>
>> https://codereview.chromium.org/66303010/
>>
>
>

-- 
You received this message because you are subscribed to the Google Groups
"Native-Client-Reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to native-client-reviews+unsubscribe@googlegroups.com.
To post to this group, send email to native-client-reviews@googlegroups.com.
Visit this group at http://groups.google.com/group/native-client-reviews.
For more options, visit https://groups.google.com/groups/opt_out.

[Yoshisato Yanagisawa, 2013-12-05 06:26:47]

Oops, I updated to here by mistake.
Bad news is I do not have the previous message...