Enables goma from GYP.

build/build_nexe.py

 #!/usr/bin/python
 # Copyright (c) 2012 The Native Client Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """NEXE building script
 
 This module will take a set of source files, include paths, library paths, and
 additional arguments, and use them to build.
 """
@@ skipping 80 matching lines @@
   if not out_ts or not src_ts:
     return True
 
   # If just rebuilt timestamps may be equal due to time granularity.
   if rebuilt:
     return out_ts < src_ts
   # If about to build, be conservative and rebuilt just in case.
   return out_ts <= src_ts
 
 
-def GetGomaPath(osname, arch, toolname):
+def GetGomaConfig(gomadir, osname, arch, toolname):
   """Returns full-path of gomacc if goma is available or None."""
   # Start goma support from os/arch/toolname that have been tested.
   # Set NO_NACL_GOMA=true to force to avoid using goma.
-  if (osname != 'linux' or arch not in ['x86-32', 'x86-64']
+  if (osname not in ['linux']

[bradn, 2013/11/12 22:32:56]

why this change?

[Yoshisato Yanagisawa, 2013/11/12 23:01:24]

For ease of adding new OS but I understand one change list should usually have
one goal.
I will make another change list for adding new os.

+      or arch not in ['x86-32', 'x86-64']
       or toolname not in ['newlib', 'glibc']
       or os.environ.get('NO_NACL_GOMA', None)):
-    return None
+    return {}
 
+  goma_config = {}
   try:
     gomacc_base = 'gomacc.exe' if os.name == 'nt' else 'gomacc'
-    for directory in os.environ.get('PATH', '').split(os.path.pathsep):
+    search_path = os.environ.get('PATH', '').split(os.path.pathsep)
+    # Use GOMA_DIR environmental variable if exist.
+    goma_dir_env = os.environ.get('GOMA_DIR', None)
+    if goma_dir_env:
+      search_path.insert(0, gomadir_env)
+    # Use gomadir in the command argument.

[bradn, 2013/11/12 22:32:56]

Maybe make clear that the command line trumps the environment?

[Yoshisato Yanagisawa, 2013/11/12 23:01:24]

Done.

+    if gomadir:
+      search_path.insert(0, gomadir)
+    for directory in search_path:
       gomacc = os.path.join(directory, gomacc_base)
       if os.path.isfile(gomacc):
         port = subprocess.Popen(
             [gomacc, 'port'], stdout=subprocess.PIPE).communicate()[0].strip()
         if port:
           status = urllib2.urlopen(
               'http://127.0.0.1:%s/healthz' % port).read().strip()
           if status == 'ok':
-            return gomacc
+            goma_config['gomacc'] = gomacc
+            break
   except Exception:
     # Anyway, fallbacks to non-goma mode.
     pass
-  return None
+
+  if goma_config:
+    goma_config['burst'] = False
+    if osname == 'linux' and not os.environ.get('NO_NACL_GOMA_BURST', None):
+      goma_config['burst'] = True
+  return goma_config
 
 
 class Builder(object):
   """Builder object maintains options and generates build command-lines.
 
   The Builder object takes a set of script command-line options, and generates
   a set of paths, and command-line options for the NaCl toolchain.
   """
   def __init__(self, options):
     arch = options.arch
@@ skipping 80 matching lines @@
     self.BuildCompileOptions(options.compile_flags, self.define_list)
     self.BuildLinkOptions(options.link_flags)
     self.BuildArchiveOptions()
     self.verbose = options.verbose
     self.suffix = options.suffix
     self.strip = options.strip
     self.empty = options.empty
     self.strip_all = options.strip_all
     self.strip_debug = options.strip_debug
     self.finalize_pexe = options.finalize_pexe and arch == 'pnacl'
-    self.gomacc = GetGomaPath(self.osname, arch, toolname)
+    goma_config = GetGomaConfig(options.gomadir, self.osname, arch, toolname)
+    self.gomacc = goma_config.get('gomacc', '')
+    self.goma_burst = goma_config.get('burst', False)
 
     # Use unoptimized native objects for debug IRT builds for faster compiles.
     if (self.is_pnacl_toolchain
         and (self.outtype == 'nlib'
              or self.outtype == 'nexe')
         and self.arch != 'pnacl'):
       if (options.build_config is not None
           and options.build_config == 'Debug'):
         self.compile_options.extend(['--pnacl-allow-translate',
                                      '--pnacl-allow-native',
@@ skipping 453 matching lines @@
   parser.add_option('--defines', dest='defines',
                     help='Set defines')
   parser.add_option('--link_flags', dest='link_flags',
                     help='Set link flags.')
   parser.add_option('-v', '--verbose', dest='verbose', default=False,
                     help='Enable verbosity', action='store_true')
   parser.add_option('-t', '--toolpath', dest='toolpath',
                     help='Set the path for of the toolchains.')
   parser.add_option('--config-name', dest='build_config',
                     help='GYP build configuration name (Release/Debug)')
+  parser.add_option('--gomadir', dest='gomadir',
+                    help='Path of the goma directory.')
   options, files = parser.parse_args(argv[1:])
 
   if not argv:
     parser.print_help()
     return 1
 
   try:
     if options.source_list:
       source_list_handle = open(options.source_list, 'r')
       source_list = source_list_handle.read().splitlines()
@@ skipping 14 matching lines @@
     build = Builder(options)
     objs = []
 
     if build.outtype == 'translate':
       # Just translate a pexe to a nexe
       if len(files) != 1:
         parser.error('Pexe translation requires exactly one input file.')
       build.Translate(list(files)[0])
       return 0
 
-    if build.gomacc:  # use goma build.
+    if build.gomacc and build.goma_burst:  # execute gomacc as many as possible.
       returns = Queue.Queue()
       def CompileThread(filename, queue):
         try:
           queue.put(build.Compile(filename))
         except Exception:
           # Put current exception info to the queue.
           queue.put(sys.exc_info())
       build_threads = []
       # Start parallel build.
       for filename in files:
@@ skipping 24 matching lines @@
       shutil.copy(objs[0], options.name)
     else:
       build.Generate(objs)
     return 0
   except Error as e:
     sys.stderr.write('%s\n' % e)
     return 1
 
 if __name__ == '__main__':
   sys.exit(Main(sys.argv))