Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(472)

Issue 663023008: Remove deprecated and unused run_and_throw_if_fail from webkitpy (Closed)

Created:
6 years, 2 months ago by kkristof
Modified:
6 years, 2 months ago
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Remove deprecated and unused run_and_throw_if_fail from webkitpy This function was used by build-webkit according to it's comment. Currently it is used by FlakyTests and some unit tests but it can be replaced with run_command Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184157

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -51 lines) Patch
M Tools/Scripts/webkitpy/common/checkout/scm/scm_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M Tools/Scripts/webkitpy/common/system/executive.py View 2 chunks +0 lines, -30 lines 0 comments Download
M Tools/Scripts/webkitpy/common/system/executive_mock.py View 1 chunk +0 lines, -11 lines 0 comments Download
M Tools/Scripts/webkitpy/common/system/executive_unittest.py View 1 chunk +0 lines, -7 lines 0 comments Download
M Tools/Scripts/webkitpy/tool/commands/flakytests.py View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
kkristof
6 years, 2 months ago (2014-10-21 08:13:07 UTC) #2
Dirk Pranke
lgtm
6 years, 2 months ago (2014-10-21 19:14:14 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/663023008/1
6 years, 2 months ago (2014-10-22 08:21:17 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-10-22 09:36:42 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 184157

Powered by Google App Engine
This is Rietveld 408576698