Tools/Scripts/webkitpy/tool/commands/flakytests.py - Issue 663023008: Remove deprecated and unused run_and_throw_if_fail from webkitpy

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Tools/Scripts/webkitpy/tool/commands/flakytests.py

Issue 663023008: Remove deprecated and unused run_and_throw_if_fail from webkitpy (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Tools/Scripts/webkitpy/tool/commands/flakytests.py

diff --git a/Tools/Scripts/webkitpy/tool/commands/flakytests.py b/Tools/Scripts/webkitpy/tool/commands/flakytests.py

index 852f8f7768b3fbe5cf28fd2efb0203a1afc553f2..0b3929adb89387131b82c106abdd93f6f3226713 100644

--- a/Tools/Scripts/webkitpy/tool/commands/flakytests.py

+++ b/Tools/Scripts/webkitpy/tool/commands/flakytests.py

@@ -98,11 +98,11 @@ class FlakyTests(AbstractDeclarativeCommand):

commit_message = self.COMMIT_MESSAGE % ','.join(reviewer_emails)

git_cmd = ['git', 'commit', '-m', commit_message,

tool.filesystem.join(tool.scm().checkout_root, flaky_tests_path)]

- tool.executive.run_and_throw_if_fail(git_cmd)

+ tool.executive.run_command(git_cmd)

git_cmd = ['git', 'cl', 'upload', '--send-mail', '-f',

'--cc', ','.join(self.ALWAYS_CC)]

- tool.executive.run_and_throw_if_fail(git_cmd)

+ tool.executive.run_command(git_cmd)

def execute(self, options, args, tool):

factory = self.expectations_factory()

« no previous file with comments | « Tools/Scripts/webkitpy/common/system/executive_unittest.py ('k') | no next file » | no next file with comments »