Mojo: mojob.sh: Make --release (etc.) work properly again.

mojo/tools/mojob.sh

Index: mojo/tools/mojob.sh
diff --git a/mojo/tools/mojob.sh b/mojo/tools/mojob.sh
index 7092c791f696995a5e2109b721a7f6a375404b56..8b2577371a78ff801893bdb5b269d81cc3329f9b 100755
--- a/mojo/tools/mojob.sh
+++ b/mojo/tools/mojob.sh
@@ -101,9 +101,20 @@ COMPILER=clang
 GOMA=auto
 make_gn_args() {
   local args=()
+  # TODO(vtl): It's a bit of a hack to infer the build type from the output
+  # directory name, but it's what we have right now (since we support "debug and
+  # release" mode).
+  case "$1" in
+    Debug)
+      # (Default.)
+      ;;
+    Release)
+      args+=("is_debug=false")

[jamesr, 2014/10/21 01:21:11]

just need an 'if' here and not a case, right?

+      ;;
+  esac
   case "$COMPILER" in
     clang)
-      args+=("is_clang=true")
+      # (Default.)

[jamesr, 2014/10/21 01:21:11]

we can change the default of clang - my comment was *only* about is_debug, which
I dont' think we will ever be able to change in the GN configuration

       ;;
     gcc)
       args+=("is_clang=false")
@@ -116,11 +127,11 @@ make_gn_args() {
       elif [ -d "${HOME}/goma" ]; then
         args+=("use_goma=true" "goma_dir=\"${HOME}/goma\"")
       else

[jamesr, 2014/10/21 01:21:11]

can just get rid of this branch, no?

-        args+=("use_goma=false")
+        # (Default.)
       fi
       ;;
     disabled)

[jamesr, 2014/10/21 01:21:11]

and get rid of this and simplify the 'case' to just an if ?

-      args+=("use_goma=false")
+      # (Default.)
       ;;
   esac
   echo "${args[*]}"